Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(694)

Issue 1042633002: Add support for -tags to enable appengine testing. (Closed)

Created:
5 years, 9 months ago by iannucci
Modified:
5 years, 8 months ago
Reviewers:
Vadim Sh.
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Add support for -tags to enable appengine testing. Will let us support packages which require -tags=appengine to build correctly! R=vadimsh@chromium.org BUG= Committed: https://chromium.googlesource.com/infra/infra/+/f867da8c88f1dbf34a6e245cba2c859bb89b2fa6

Patch Set 1 #

Total comments: 1

Patch Set 2 : remove comma #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M go/src/infra/gae/apps/helloworld/app_test.go View 1 chunk +2 lines, -0 lines 0 comments Download
M go/src/infra/gae/apps/helloworld/helloworld.infra_testing View 1 chunk +2 lines, -1 line 0 comments Download
M go/test.py View 1 3 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
iannucci
5 years, 9 months ago (2015-03-28 23:30:16 UTC) #1
Vadim Sh.
lgtm how does goconvey discover what tags to use? https://codereview.chromium.org/1042633002/diff/1/go/test.py File go/test.py (right): https://codereview.chromium.org/1042633002/diff/1/go/test.py#newcode183 go/test.py:183: ...
5 years, 8 months ago (2015-03-30 06:05:40 UTC) #3
iannucci
On 2015/03/30 06:05:40, Vadim Sh. wrote: > lgtm > > how does goconvey discover what ...
5 years, 8 months ago (2015-03-30 19:20:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1042633002/40001
5 years, 8 months ago (2015-04-04 04:21:00 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-04 04:23:29 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/infra/infra/+/f867da8c88f1dbf34a6e245cba2c8...

Powered by Google App Engine
This is Rietveld 408576698