add video hole support to the gn build

build/config/features.gni

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # This file contains UI-related build flags. It should theoretically be in the
 # src/ui directory and only things that depend on the ui module should get the
 # definitions.
 #
 # However, today we have many "bad" dependencies on some of these flags from,
 # e.g. base, so they need to be global.
@@ skipping 56 matching lines @@
 
   enable_supervised_users = !is_ios
 
   enable_autofill_dialog = !is_ios
 
   enable_google_now = !is_ios && !is_android
 
   enable_one_click_signin = is_win || is_mac || (is_linux && !is_chromeos)
 
   enable_remoting = !is_ios && !is_android
+
+  # Should we enable hole punching for protected video?

[tfarina, 2015/03/31 16:17:06]

I tend to prefer to keep this comment equal to the GYP version, just changing
'Set to 1' to 'Set to true'...

[Mostyn Bramley-Moore, 2015/03/31 16:25:20]

I reworded this to improve the grammar.  Would you prefer my version be added to
build/common.gypi or that version here instead?

[Mostyn Bramley-Moore, 2015/04/01 07:52:43]

I changed this to be the same as the gyp comment.  We can fix both later if you
like.

+  enable_video_hole = is_android

[tfarina, 2015/03/31 16:17:07]

Should this be = false? How GYP enables this? It seems to be set to 0 there.

[Mostyn Bramley-Moore, 2015/03/31 16:25:20]

build/common.gypi has defaults for this in three places...

line 624 (not inside a condition AFAICT): default to 0
line 778: (inside an OS=="android" condition): default to 1
line 1844: (inside a chromecast==1 condition): default to 1

I couldn't find a chromecast gn variable or argument.

 }
 
 # Additional dependent variables -----------------------------------------------
 
 # Set the version of CLD.
 #   0: Don't specify the version. This option is for the Finch testing.
 #   1: Use only CLD1.
 #   2: Use only CLD2.
 if (is_android) {
   cld_version = 1
@@ skipping 87 matching lines @@
 # TODO(GYP) also require !embedded to enable.
 use_gconf = is_linux && !is_chromeos
 
 # Hangout services is an extension that adds extra features to Hangouts.
 # For official GYP builds, this flag is set, it will likely need to be
 # parameterized in the future for a similar use.
 enable_hangout_services_extension = false
 
 # Whether to back up data before sync.
 enable_pre_sync_backup = is_win || is_mac || (is_linux && !is_chromeos)