Source/modules/vibration/NavigatorVibration.cpp - Issue 1042513002: Add the vibrate attribute to the Notification object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/vibration/NavigatorVibration.cpp

Issue 1042513002: Add the vibrate attribute to the Notification object (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp ('K') | « Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp ('k') | public/platform/WebVibration.h » ('j') | public/platform/WebVibration.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/vibration/NavigatorVibration.cpp

diff --git a/Source/modules/vibration/NavigatorVibration.cpp b/Source/modules/vibration/NavigatorVibration.cpp

index b8fd026b8522b4fe913424749140cd41d38e458a..bbecfd463f100691c6c1a34d9e073c333c61db83 100644

--- a/Source/modules/vibration/NavigatorVibration.cpp

+++ b/Source/modules/vibration/NavigatorVibration.cpp

@@ -28,9 +28,6 @@

namespace blink {

-// Maximum number of entries in a vibration pattern.

-const unsigned kVibrationPatternLengthMax = 99;

NavigatorVibration::NavigatorVibration(Page& page)

: PageLifecycleObserver(&page)

, m_timerStart(this, &NavigatorVibration::timerStartFired)