Chromium Code Reviews| Index: Source/modules/notifications/NotificationOptions.idl |
| diff --git a/Source/modules/notifications/NotificationOptions.idl b/Source/modules/notifications/NotificationOptions.idl |
| index 716ce68f4ea9ae8c1bc3eadbb29dbcf4536f7859..2965f978a4cd92021e00468588a63d2c07cbefbd 100644 |
| --- a/Source/modules/notifications/NotificationOptions.idl |
| +++ b/Source/modules/notifications/NotificationOptions.idl |
| @@ -16,6 +16,11 @@ dictionary NotificationOptions { |
| DOMString body = ""; |
| DOMString tag = ""; |
| DOMString icon; |
| + // FIXME: The Union type VibrationPattern is not supported in NavigatorVibration. |
|
Peter Beverloo
2015/04/07 11:37:31
nit: We switched to attributed TODOs rather than u
Sanghyun Park
2015/04/08 08:00:03
Okay I'll fix this.
|
| + // If VibrationPattern is supported, we need to change with this. |
|
Peter Beverloo
2015/04/07 11:37:31
I think it would make sense to fix Issue 240176 fi
Sanghyun Park
2015/04/08 08:00:03
I tried to make VibrationPattern union type like [
Peter Beverloo
2015/04/08 16:40:01
Ok, but please make sure that there's a bug. Also,
Sanghyun Park
2015/04/08 17:20:59
Sure, I've search the bug, I could not find someth
|
| + // FIXME: The contents of the pattern argument should be clamped. |
| + // See https://code.google.com/p/chromium/issues/detail?id=310138 |
| + [RuntimeEnabled=NotificationExperimental] (unsigned long or sequence<unsigned long>) vibrate; |
| boolean silent = false; |
| [RuntimeEnabled=NotificationExperimental] any data = null; |
| }; |