Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: Source/modules/notifications/NotificationOptions.idl

Issue 1042513002: Add the vibrate attribute to the Notification object (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: WebNotificationVibrationData is renamed WebNotificationVibratePattern Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/notifications/NotificationOptions.idl
diff --git a/Source/modules/notifications/NotificationOptions.idl b/Source/modules/notifications/NotificationOptions.idl
index 716ce68f4ea9ae8c1bc3eadbb29dbcf4536f7859..2965f978a4cd92021e00468588a63d2c07cbefbd 100644
--- a/Source/modules/notifications/NotificationOptions.idl
+++ b/Source/modules/notifications/NotificationOptions.idl
@@ -16,6 +16,11 @@ dictionary NotificationOptions {
DOMString body = "";
DOMString tag = "";
DOMString icon;
+ // FIXME: The Union type VibrationPattern is not supported in NavigatorVibration.
Peter Beverloo 2015/04/07 11:37:31 nit: We switched to attributed TODOs rather than u
Sanghyun Park 2015/04/08 08:00:03 Okay I'll fix this.
+ // If VibrationPattern is supported, we need to change with this.
Peter Beverloo 2015/04/07 11:37:31 I think it would make sense to fix Issue 240176 fi
Sanghyun Park 2015/04/08 08:00:03 I tried to make VibrationPattern union type like [
Peter Beverloo 2015/04/08 16:40:01 Ok, but please make sure that there's a bug. Also,
Sanghyun Park 2015/04/08 17:20:59 Sure, I've search the bug, I could not find someth
+ // FIXME: The contents of the pattern argument should be clamped.
+ // See https://code.google.com/p/chromium/issues/detail?id=310138
+ [RuntimeEnabled=NotificationExperimental] (unsigned long or sequence<unsigned long>) vibrate;
boolean silent = false;
[RuntimeEnabled=NotificationExperimental] any data = null;
};

Powered by Google App Engine
This is Rietveld 408576698