LayoutTests/http/tests/notifications/serviceworkerregistration-document-vibrate.html - Issue 1042513002: Add the vibrate attribute to the Notification object

Unified Diff: LayoutTests/http/tests/notifications/serviceworkerregistration-document-vibrate.html

Issue 1042513002: Add the vibrate attribute to the Notification object (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: WebNotificationVibrationData is renamed WebNotificationVibratePattern Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/notifications/notification-properties.html ('k') | LayoutTests/http/tests/notifications/serviceworkerregistration-document-vibrate-throw.html » ('j') | LayoutTests/http/tests/notifications/serviceworkerregistration-document-vibrate-throw.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/notifications/serviceworkerregistration-document-vibrate.html

diff --git a/LayoutTests/http/tests/notifications/serviceworkerregistration-document-direction.html b/LayoutTests/http/tests/notifications/serviceworkerregistration-document-vibrate.html

similarity index 86%

copy from LayoutTests/http/tests/notifications/serviceworkerregistration-document-direction.html

copy to LayoutTests/http/tests/notifications/serviceworkerregistration-document-vibrate.html

index dd740cc2be38072b501d4e19a6a48ac5271007c7..9e50ab9ab4cf2fc15ec4bcba1eb3b2e6dae7fb7b 100644

--- a/LayoutTests/http/tests/notifications/serviceworkerregistration-document-direction.html

+++ b/LayoutTests/http/tests/notifications/serviceworkerregistration-document-vibrate.html

@@ -1,7 +1,7 @@

<!doctype html>

<html>

<head>

- <title>Notifications: ServiceWorkerRegistration.showNotification() shows notification with correct notification direction.</title>

+ <title>Notifications: ServiceWorkerRegistration.showNotification() shows notification with correct notification vibrate.</title>

@@ -10,9 +10,8 @@

<body>

// Tests that the showNotification() function resolves a promise, and that the

- // notificationclick event gets fired with the correct notification direction.

+ // notificationclick event gets fired with the correct notification vibrate.

// This test requires the test runner.

async_test(function(test) {

var scope = 'resources/spec/' + location.pathname,

script = 'resources/instrumentation-service-worker.js';

@@ -25,7 +24,7 @@

// (1) Display a Web Notification from the document.

return workerInfo.registration.showNotification(scope, {

- dir: 'rtl'

+ vibrate: [100, 200, 300]

});

}).then(function() {

// (2) Simulate a click on the notification that has been displayed.

@@ -37,16 +36,15 @@

return;

}

- // (3) Verify that the click event was received by the Service Worker,

- // and that the correct direction was passed along.

+ // (3) Verify that the click event was received by the Service Worker

assert_equals(event.data.command, 'click');

- assert_equals(event.data.notification.dir, 'rtl');

+ // FIXME: Verify that the correct vibrate is returned or not.

Peter Beverloo 2015/04/07 11:37:31 This test doesn't actually test anything. Can we r

Sanghyun Park 2015/04/08 08:00:02 Sure, After the this implementation is completed u

test.done();

});

}).catch(unreached_rejection(test));

- }, 'Clicking on a notification displayed through showNotification() fires a Service Worker event with the correct notification direction');

+ }, 'Clicking on a notification displayed through showNotification() fires a Service Worker event with the correct notification virate');

</script>

</body>

</html>