Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Unified Diff: public/platform/modules/notifications/WebNotificationData.h

Issue 1042513002: Add the vibrate attribute to the Notification object (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: public/platform/modules/notifications/WebNotificationData.h
diff --git a/public/platform/modules/notifications/WebNotificationData.h b/public/platform/modules/notifications/WebNotificationData.h
index c1f0a5370e8b88e615303b0725622b379dc1cfc3..2702209f5c145a5743c0e70ce134979055caafab 100644
--- a/public/platform/modules/notifications/WebNotificationData.h
+++ b/public/platform/modules/notifications/WebNotificationData.h
@@ -7,6 +7,7 @@
#include "public/platform/WebString.h"
#include "public/platform/WebURL.h"
+#include "public/platform/WebVector.h"
namespace blink {
@@ -35,13 +36,14 @@ struct WebNotificationData {
{
}
- WebNotificationData(const WebString& title, Direction direction, const WebString& lang, const WebString& body, const WebString& tag, const WebURL& icon, bool silent, const WebString& data)
+ WebNotificationData(const WebString& title, Direction direction, const WebString& lang, const WebString& body, const WebString& tag, const WebURL& icon, const WebVector<unsigned>& vibrate, bool silent, const WebString& data)
Peter Beverloo 2015/04/01 14:26:29 nit: you'll need another temporary constructor, si
Sanghyun Park 2015/04/01 17:46:08 Done.
: title(title)
, direction(direction)
, lang(lang)
, body(body)
, tag(tag)
, icon(icon)
+ , vibrate(vibrate)
, silent(silent)
, data(data)
{
@@ -53,6 +55,7 @@ struct WebNotificationData {
WebString body;
WebString tag;
WebURL icon;
+ WebVector<unsigned> vibrate;
bool silent;
WebString data;
};

Powered by Google App Engine
This is Rietveld 408576698