Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Unified Diff: LayoutTests/http/tests/notifications/notification-properties.html

Issue 1042513002: Add the vibrate attribute to the Notification object (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/modules/notifications/DEPS » ('j') | Source/modules/notifications/Notification.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/http/tests/notifications/notification-properties.html
diff --git a/LayoutTests/http/tests/notifications/notification-properties.html b/LayoutTests/http/tests/notifications/notification-properties.html
index a70e818510478fc4a550c742f9e47697a210b247..5cff9653a5724597e542c6d4caf745b11a30d743 100644
--- a/LayoutTests/http/tests/notifications/notification-properties.html
+++ b/LayoutTests/http/tests/notifications/notification-properties.html
@@ -66,7 +66,20 @@
// Setting an empty string as the tag should be equal to not setting the tag at all.
assert_equals(noTagNotification.tag, emptyTagNotification.tag);
+ // Tests that sequence<unsigned long> input no throws exceptions.
Peter Beverloo 2015/04/01 14:26:29 sequence<unsigned long> doesn't mean anything to J
Sanghyun Park 2015/04/01 17:46:08 I'll fix this.
+ var vibrateNotification = new Notification("My Notification", {
+ vibrate: [100, 2000, 1000]
+ });
+
+ // Verifying the exception throwing behavior, when slient set true and vibrate is presented.
Peter Beverloo 2015/04/01 14:26:29 Could you add a test for ServiceWorkerRegistration
Sanghyun Park 2015/04/01 17:46:08 Okay I'll add test of ServiceWorkerRegistration.sh
+ assert_throws(new TypeError(), function() {
+ var notification = new Notification('Title', {
Peter Beverloo 2015/04/01 14:26:29 nit: Please be consistent with ' vs. " for definin
Sanghyun Park 2015/04/01 17:46:08 Done.
+ silent: true,
+ vibrate: 1000
+ });
+ }, 'Set vibrate, when slient is true.');
+
}, 'Checks the properties exposed on the Notification object.');
</script>
</body>
-</html>
+</html>
« no previous file with comments | « no previous file | Source/modules/notifications/DEPS » ('j') | Source/modules/notifications/Notification.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698