Add the vibrate attribute to the Notification object

Source/modules/vibration/NavigatorVibration.cpp

 /*
  *  Copyright (C) 2012 Samsung Electronics
  *
  *  This library is free software; you can redistribute it and/or
  *  modify it under the terms of the GNU Library General Public
  *  License as published by the Free Software Foundation; either
  *  version 2 of the License, or (at your option) any later version.
  *
  *  This library is distributed in the hope that it will be useful,
  *  but WITHOUT ANY WARRANTY; without even the implied warranty of
  *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  *  Library General Public License for more details.
  *
  *  You should have received a copy of the GNU Library General Public License
  *  along with this library; see the file COPYING.LIB.  If not, write to
  *  the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
  *  Boston, MA 02110-1301, USA.
  */
 
 #include "config.h"
 #include "modules/vibration/NavigatorVibration.h"
 
+#include "bindings/modules/v8/UnionTypesModules.h"
 #include "core/frame/LocalFrame.h"
 #include "core/frame/Navigator.h"
 #include "core/page/PageVisibilityState.h"
 #include "public/platform/Platform.h"
 #include "public/platform/WebVibration.h"
 
 namespace blink {
 
 // Maximum number of entries in a vibration pattern.
 const unsigned kVibrationPatternLengthMax = 99;

[timvolodine, 2015/04/16 12:38:01]

btw this can probably also go into the anonymous namespace

[Peter Beverloo, 2015/04/16 12:46:41]

(Constants are file-local by default, no need for them to be in an anonymous
namespace. This also goes for strings and all.)

[Sanghyun Park, 2015/04/16 13:17:30]

This constants is used in sanitizedVibrationPatternInternal function.
I think this also should go into anonymous namespace for using this value in
sanitizedVibrationPatternInternal.

WDYT?

 
-NavigatorVibration::NavigatorVibration(Page& page)
-    : PageLifecycleObserver(&page)
-    , m_timerStart(this, &NavigatorVibration::timerStartFired)
-    , m_timerStop(this, &NavigatorVibration::timerStopFired)
-    , m_isVibrating(false)
+static NavigatorVibration::VibrationPattern sanitizeVibrationPatternInternal(const NavigatorVibration::VibrationPattern& pattern)

[timvolodine, 2015/04/16 12:38:01]

no need for 'static' here, and why not put this method in an anonymous
namespace?

[Peter Beverloo, 2015/04/16 12:46:41]

+1, please use an anonymous namespace for the function.

[Sanghyun Park, 2015/04/16 13:17:30]

I just want to avoid using same blink namespace in this function.

I'll remove 'static' and move to anonymous space.

[timvolodine, 2015/04/16 13:17:51]

yes, and just to clarify: I meant you can drop static if you use an anonymous
namespace ;)

 {
-}
-
-NavigatorVibration::~NavigatorVibration()
-{
-    if (m_isVibrating)
-        cancelVibration();
-}
-
-bool NavigatorVibration::vibrate(const VibrationPattern& pattern)
-{
-    VibrationPattern sanitized = pattern;
+    NavigatorVibration::VibrationPattern sanitized = pattern;
     size_t length = sanitized.size();
 
     // If the pattern is too long then truncate it.
     if (length > kVibrationPatternLengthMax) {
         sanitized.shrink(kVibrationPatternLengthMax);
         length = kVibrationPatternLengthMax;
     }
 
     // If any pattern entry is too long then truncate it.
     for (size_t i = 0; i < length; ++i) {
         if (sanitized[i] > kVibrationDurationMax)
             sanitized[i] = kVibrationDurationMax;
     }
 
     // If the last item in the pattern is a pause then discard it.
     if (length && !(length % 2))
         sanitized.removeLast();
 
+    return sanitized;
+}
+
+NavigatorVibration::VibrationPattern NavigatorVibration::sanitizeVibrationPattern(const UnsignedLongOrUnsignedLongSequence& pattern)
+{
+    VibrationPattern sanitized;
+
+    if (pattern.isUnsignedLong())
+        sanitized.append(pattern.getAsUnsignedLong());
+    else if (pattern.isUnsignedLongSequence())
+        sanitized = pattern.getAsUnsignedLongSequence();
+
+    return sanitizeVibrationPatternInternal(sanitized);
+}
+
+NavigatorVibration::NavigatorVibration(Page& page)
+    : PageLifecycleObserver(&page)
+    , m_timerStart(this, &NavigatorVibration::timerStartFired)
+    , m_timerStop(this, &NavigatorVibration::timerStopFired)
+    , m_isVibrating(false)
+{
+}
+
+NavigatorVibration::~NavigatorVibration()
+{
+    if (m_isVibrating)
+        cancelVibration();
+}
+
+bool NavigatorVibration::vibrate(const VibrationPattern& pattern)
+{
     // Cancelling clears the stored pattern so do it before setting the new one.
     if (m_isVibrating)
         cancelVibration();
 
-    m_pattern = sanitized;
+    m_pattern = sanitizeVibrationPatternInternal(pattern);
 
     if (m_timerStart.isActive())
         m_timerStart.stop();
 
     if (!m_pattern.size())
         return true;
 
     if (m_pattern.size() == 1 && !m_pattern[0]) {
         m_pattern.clear();
         return true;
@@ skipping 89 matching lines @@
     return "NavigatorVibration";
 }
 
 DEFINE_TRACE(NavigatorVibration)
 {
     WillBeHeapSupplement<Page>::trace(visitor);
     PageLifecycleObserver::trace(visitor);
 }
 
 } // namespace blink