public/platform/WebVibration.h - Issue 1042513002: Add the vibrate attribute to the Notification object

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: public/platform/WebVibration.h

Issue 1042513002: Add the vibrate attribute to the Notification object (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp ('K') | « Source/modules/vibration/NavigatorVibration.cpp ('k') | public/platform/modules/notifications/WebNotificationData.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2013 Google Inc. All rights reserved.	2 * Copyright (C) 2013 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 18 matching lines...) Expand all Loading...
29 */	29 */

30	30

31 #ifndef WebVibration_h	31 #ifndef WebVibration_h

32 #define WebVibration_h	32 #define WebVibration_h

33	33

34 namespace blink {	34 namespace blink {

35	35

36 // Maximum duration of a vibration is 10 seconds.	36 // Maximum duration of a vibration is 10 seconds.

37 const unsigned kVibrationDurationMax = 10000;	37 const unsigned kVibrationDurationMax = 10000;

38	38

	39 // Maximum number of entries in a vibration pattern.

	40 const unsigned kVibrationPatternLengthMax = 99;
	Peter Beverloo 2015/04/09 13:03:17 Note that you're exposing this in the Blink API, b Note that you're exposing this in the Blink API, but aren't actually using it anywhere new. If you group all vibration pattern sanitation to NavigatorVibration then it can remain file-private to that file, and you don't have to touch this part of the API. Sanghyun Park 2015/04/09 13:48:05 Okay, I'll remove this. Show quoted text On 2015/04/09 13:03:17, Peter Beverloo wrote: > Note that you're exposing this in the Blink API, but aren't actually using it > anywhere new. > > If you group all vibration pattern sanitation to NavigatorVibration then it can > remain file-private to that file, and you don't have to touch this part of the > API. Okay, I'll remove this.
	41

39 } // namespace blink	42 } // namespace blink

40	43

41 #endif // WebVibration_h	44 #endif // WebVibration_h

OLD	NEW