Add the vibrate attribute to the Notification object

Source/modules/notifications/Notification.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 34 matching lines @@
 #include "wtf/RefCounted.h"
 #include "wtf/RefPtr.h"
 
 namespace blink {
 
 class ExecutionContext;
 class NotificationOptions;
 class NotificationPermissionCallback;
 class ScriptState;
 class ScriptValue;
+class UnsignedLongOrUnsignedLongSequence;
 struct WebNotificationData;
 
 class Notification final : public RefCountedGarbageCollectedEventTargetWithInlineData<Notification>, public ActiveDOMObject, public WebNotificationDelegate {
     DEFINE_EVENT_TARGET_REFCOUNTING_WILL_BE_REMOVED(RefCountedGarbageCollected<Notification>);
     WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(Notification);
     DEFINE_WRAPPERTYPEINFO();
 public:
     // Used for JavaScript instantiations of the Notification object. Will automatically schedule for
     // the notification to be displayed to the user.
     static Notification* create(ExecutionContext*, const String& title, const NotificationOptions&, ExceptionState&);
@@ skipping 15 matching lines @@
     void dispatchClickEvent() override;
     void dispatchErrorEvent() override;
     void dispatchCloseEvent() override;
 
     String title() const { return m_title; }
     String dir() const { return m_dir; }
     String lang() const { return m_lang; }
     String body() const { return m_body; }
     String tag() const { return m_tag; }
     String icon() const { return m_iconUrl; }
+    Vector<unsigned> vibrate(bool& isNull) const;
     bool silent() const { return m_silent; }
     ScriptValue data(ScriptState*) const;
 
     TextDirection direction() const;
     KURL iconURL() const { return m_iconUrl; }
     SerializedScriptValue* serializedData() const { return m_serializedData.get(); }
 
     static String permissionString(WebNotificationPermission);
     static String permission(ExecutionContext*);
     static WebNotificationPermission checkPermission(ExecutionContext*);
     static void requestPermission(ExecutionContext*, NotificationPermissionCallback* = nullptr);
+    static Vector<unsigned> sanitizeVibrationPattern(const UnsignedLongOrUnsignedLongSequence&);

[Peter Beverloo, 2015/04/09 13:03:17]

I don't think this should be the responsibility of anything in
modules/notifications/, not least of all because it doesn't implement the
specification or any of the sanity checks.

The NavigatorVibration::vibrate() method implements the sanitation algorithm as
specified by the Vibration API. Why don't you extract that to a static method
and use it here (and in SWRNotifications)?

http://dev.w3.org/2009/dap/vibration/#dfn-validate-and-normalize

[Sanghyun Park, 2015/04/09 13:48:05]

If we use sanitation algorithm in Vibration API, we cannot keep user's setting
value in vibrate.
So I made other things in Notification class.

For example, If we use sanitation algorithm in Vibration API, when User set
[1000, 2000, 10000, 200] in NotificationOptions's vibrate property,
Notification.vibrate will return [1000, 2000, 10000].
Becuase sanitation algorithm delete last valuse, when vibrate's count is even.

Then I thought again, we don't need to keep user's setting no matched with
sanitation algorithms.

I'll fix to use Vibration API's sanitation algorithms.

[Peter Beverloo, 2015/04/09 13:53:07]

Yes, and that's exactly the point :-). We don't have to return exactly what the
developer provided - we don't do that in some other cases either (e.g.
directionality and the icon URL), as long as it results in a valid value
representing the same thing.

Thanks for moving to using Vibration's sanitation algorithm.

[Sanghyun Park, 2015/04/09 16:26:11]

Thanks for letting me know about this, too. :)

 
     // EventTarget interface.
     virtual ExecutionContext* executionContext() const override final { return ActiveDOMObject::executionContext(); }
     virtual bool dispatchEvent(PassRefPtrWillBeRawPtr<Event>) override final;
     virtual const AtomicString& interfaceName() const override;
 
     // ActiveDOMObject interface.
     virtual void stop() override;
     virtual bool hasPendingActivity() const override;
 
     DECLARE_VIRTUAL_TRACE();
 
 private:
     Notification(const String& title, ExecutionContext*);
 
     void scheduleShow();
 
     // Calling show() may start asynchronous operation. If this object has
     // a V8 wrapper, hasPendingActivity() prevents the wrapper from being
     // collected while m_state is Showing, and so this instance stays alive
     // until the operation completes. Otherwise, you need to hold a ref on this
     // instance until the operation completes.
     void show();
 
     void setDir(const String& dir) { m_dir = dir; }
     void setLang(const String& lang) { m_lang = lang; }
     void setBody(const String& body) { m_body = body; }
     void setIconUrl(KURL iconUrl) { m_iconUrl = iconUrl; }
     void setTag(const String& tag) { m_tag = tag; }
+    void setVibrate(const Vector<unsigned>& vibrate) { m_vibrate = vibrate; }
     void setSilent(bool silent) { m_silent = silent; }
     void setSerializedData(PassRefPtr<SerializedScriptValue> data) { m_serializedData = data; }
 
     void setPersistentId(const String& persistentId) { m_persistentId = persistentId; }
 
 private:
     String m_title;
     String m_dir;
     String m_lang;
     String m_body;
     String m_tag;
+    Vector<unsigned> m_vibrate;
     bool m_silent;
     RefPtr<SerializedScriptValue> m_serializedData;
 
     KURL m_iconUrl;
 
     // Notifications can either be bound to the page, which means they're identified by
     // their delegate, or persistent, which means they're identified by a persistent Id
     // given to us by the embedder. This influences how we close the notification.
     String m_persistentId;
 
     enum NotificationState {
         NotificationStateIdle,
         NotificationStateShowing,
         NotificationStateClosing,
         NotificationStateClosed
     };
 
     // Only to be used by the Notification::create() method when notifications were created
     // by the embedder rather than by Blink.
     void setState(NotificationState state) { m_state = state; }
 
     NotificationState m_state;
 
     AsyncMethodRunner<Notification> m_asyncRunner;
 };
 
 } // namespace blink
 
 #endif // Notification_h