Source/modules/notifications/NotificationOptions.idl - Issue 1042513002: Add the vibrate attribute to the Notification object

Side by Side Diff: Source/modules/notifications/NotificationOptions.idl

Issue 1042513002: Add the vibrate attribute to the Notification object (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: WebNotificationVibrationData is renamed WebNotificationVibratePattern Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Source/modules/notifications/Notification.idl ('K') | « Source/modules/notifications/Notification.idl ('k') | Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp » ('j') | public/platform/modules/notifications/WebNotificationVibratePattern.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // http://notifications.spec.whatwg.org/#api	5 // http://notifications.spec.whatwg.org/#api

6	6

7 enum NotificationDirection {	7 enum NotificationDirection {

8 "auto",	8 "auto",

9 "ltr",	9 "ltr",

10 "rtl"	10 "rtl"

11 };	11 };

12	12

13 dictionary NotificationOptions {	13 dictionary NotificationOptions {

14 NotificationDirection dir = "auto";	14 NotificationDirection dir = "auto";

15 DOMString lang = "";	15 DOMString lang = "";

16 DOMString body = "";	16 DOMString body = "";

17 DOMString tag = "";	17 DOMString tag = "";

18 DOMString icon;	18 DOMString icon;

	19 // FIXME: The Union type VibrationPattern is not supported in NavigatorVibra tion.
	Peter Beverloo 2015/04/07 11:37:31 nit: We switched to attributed TODOs rather than u nit: We switched to attributed TODOs rather than unattributed FIXMEs. TODO(sh919.park): Foobarbaz Sanghyun Park 2015/04/08 08:00:03 Okay I'll fix this. Show quoted text On 2015/04/07 11:37:31, Peter Beverloo wrote: > nit: We switched to attributed TODOs rather than unattributed FIXMEs. > > TODO(sh919.park): Foobarbaz Okay I'll fix this.
	20 // If VibrationPattern is supported, we need to change with this.
	Peter Beverloo 2015/04/07 11:37:31 I think it would make sense to fix Issue 240176 fi I think it would make sense to fix Issue 240176 first, that should be a very trivial ~20 line patch, and introduce the VibrationPattern union typedef in NavigatorVibration. Then we adopt that immediately. Sanghyun Park 2015/04/08 08:00:03 I tried to make VibrationPattern union type like [ Show quoted text On 2015/04/07 11:37:31, Peter Beverloo wrote: > I think it would make sense to fix Issue 240176 first, that should be a very > trivial ~20 line patch, and introduce the VibrationPattern union typedef in > NavigatorVibration. Then we adopt that immediately. I tried to make VibrationPattern union type like [1]. typedef ([Clamp] unsigned long or sequence<unsigned long>) VibratePattern; But Union type does not support [Clamp] extended attribute. So I think that we need to fix idl parser in order to make VibratePattern union type. Currently, I am finding solution to support [Clamp] extended attribute in union. I'm not familiar about idl parser, so it will take some time. So, Can I write "FIXME" in this file? After implementing extended attribute in union, I'll fix this. Peter Beverloo 2015/04/08 16:40:01 Ok, but please make sure that there's a bug. Also, Show quoted text On 2015/04/08 08:00:03, Sanghyun Park wrote: > On 2015/04/07 11:37:31, Peter Beverloo wrote: > > I think it would make sense to fix Issue 240176 first, that should be a very > > trivial ~20 line patch, and introduce the VibrationPattern union typedef in > > NavigatorVibration. Then we adopt that immediately. > > I tried to make VibrationPattern union type like [1]. > typedef ([Clamp] unsigned long or sequence<unsigned long>) VibratePattern; > > But Union type does not support [Clamp] extended attribute. > So I think that we need to fix idl parser in order to make VibratePattern union > type. > > Currently, I am finding solution to support [Clamp] extended attribute in union. > I'm not familiar about idl parser, so it will take some time. > > So, Can I write "FIXME" in this file? After implementing extended attribute in > union, I'll fix this. Ok, but please make sure that there's a bug. Also, s/FIXME/TODO(yourname)/ Sanghyun Park 2015/04/08 17:20:59 Sure, I've search the bug, I could not find someth Show quoted text On 2015/04/08 16:40:01, Peter Beverloo wrote: > On 2015/04/08 08:00:03, Sanghyun Park wrote: > > On 2015/04/07 11:37:31, Peter Beverloo wrote: > > > I think it would make sense to fix Issue 240176 first, that should be a very > > > trivial ~20 line patch, and introduce the VibrationPattern union typedef in > > > NavigatorVibration. Then we adopt that immediately. > > > > I tried to make VibrationPattern union type like [1]. > > typedef ([Clamp] unsigned long or sequence<unsigned long>) VibratePattern; > > > > But Union type does not support [Clamp] extended attribute. > > So I think that we need to fix idl parser in order to make VibratePattern > union > > type. > > > > Currently, I am finding solution to support [Clamp] extended attribute in > union. > > I'm not familiar about idl parser, so it will take some time. > > > > So, Can I write "FIXME" in this file? After implementing extended attribute in > > union, I'll fix this. > > Ok, but please make sure that there's a bug. Also, s/FIXME/TODO(yourname)/ Sure, I've search the bug, I could not find something like this. I'll use Issue 240176, when I fix this.
	21 // FIXME: The contents of the pattern argument should be clamped.

	22 // See https://code.google.com/p/chromium/issues/detail?id=310138

	23 [RuntimeEnabled=NotificationExperimental] (unsigned long or sequence<unsigne d long>) vibrate;

19 boolean silent = false;	24 boolean silent = false;

20 [RuntimeEnabled=NotificationExperimental] any data = null;	25 [RuntimeEnabled=NotificationExperimental] any data = null;

21 };	26 };

OLD	NEW