LayoutTests/http/tests/notifications/serviceworkerregistration-document-vibrate-throw.html - Issue 1042513002: Add the vibrate attribute to the Notification object

Side by Side Diff: LayoutTests/http/tests/notifications/serviceworkerregistration-document-vibrate-throw.html

Issue 1042513002: Add the vibrate attribute to the Notification object (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: WebNotificationVibrationData is renamed WebNotificationVibratePattern Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/http/tests/notifications/serviceworkerregistration-document-vibrate.html ('K') | « LayoutTests/http/tests/notifications/serviceworkerregistration-document-vibrate.html ('k') | LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt » ('j') | Source/modules/notifications/Notification.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <title>Notifications: ServiceWorkerRegistration.showNotification().</title>	4 <title>Notifications: Verifying the exception throwing behavior, when slient set true and vibrate is presented in showNotification().</title>

5 <script src="../resources/testharness.js"></script>	5 <script src="../resources/testharness.js"></script>

6 <script src="../resources/testharnessreport.js"></script>	6 <script src="../resources/testharnessreport.js"></script>

7 <script src="../serviceworker/resources/test-helpers.js"></script>	7 <script src="../serviceworker/resources/test-helpers.js"></script>

8 </head>	8 </head>

9 <body>	9 <body>

10 <script>	10 <script>

11 // Tests that the showNotification() function rejects the returned promise with a	11 // Tests that the showNotification() function rejects the returned promise with a

12 // TypeError when no permission has been granted for Web Notifications.	12 // TypeError when slient set true and vibrate is presented.

13 async_test(function(test) {	13 async_test(function(test) {

14 var scope = 'resources/scope/service-worker-show-notification-no-permi ssion',	14 var scope = 'resources/spec/' + location.pathname,
	Peter Beverloo 2015/04/07 11:37:31 why /spec/? why /spec/? Sanghyun Park 2015/04/08 08:00:02 This is my fault. I'll update to scope. Show quoted text On 2015/04/07 11:37:31, Peter Beverloo wrote: > why /spec/? This is my fault. I'll update to scope.
15 workerUrl = 'resources/empty-worker.js';	15 workerUrl = 'resources/empty-worker.js';

16	16

17 if (window.testRunner)	17 testRunner.grantWebNotificationPermission(location.origin, true);

18 testRunner.grantWebNotificationPermission(location.origin, false);

19	18

20 var registration = null;	19 var registration = null;

21 service_worker_unregister_and_register(test, workerUrl, scope).then(fu nction(swRegistration) {	20 service_worker_unregister_and_register(test, workerUrl, scope).then(fu nction(swRegistration) {

22 registration = swRegistration;	21 registration = swRegistration;

23 return wait_for_state(test, registration.installing, 'activated');	22 return wait_for_state(test, registration.installing, 'activated');

24 }).then(function() {	23 }).then(function() {

25 assert_inherits(registration, 'showNotification', 'showNotificatio n() must be exposed.');

26 registration.showNotification('Title', {	24 registration.showNotification('Title', {

27 body: 'Hello, world!',	25 body: 'Hello, world!',

28 icon: '/icon.png'	26 vibrate: [100, 200, 300],

	27 silent: true

29 }).then(function() {	28 }).then(function() {

30 assert_unreached('showNotification() is expected to reject.');	29 assert_unreached('showNotification() is expected to reject.');

31 }).catch(function(error) {	30 }).catch(function(error) {

32 assert_equals(error.name, 'TypeError');	31 assert_equals(error.name, 'TypeError');

33 assert_equals(error.message, 'No notification permission has b een granted for this origin.');	32 assert_equals(error.message, 'If options\'s silent is true, op tions\'s vibrate should not be presented.');
	Peter Beverloo 2015/04/07 11:37:31 "If options's silent is true, options's vibrate sh "If options's silent is true, options's vibrate should not be presented." --> "If the notification is set to silent while a vibration pattern has been provided, the Promise is expected to reject." Please make similar changes elsewhere, as "option's vibrate should not be presented" isn't clear. Sanghyun Park 2015/04/08 08:00:02 Okay, I'll update. Show quoted text On 2015/04/07 11:37:31, Peter Beverloo wrote: > "If options's silent is true, options's vibrate should not be presented." > --> > "If the notification is set to silent while a vibration pattern has been > provided, the Promise is expected to reject." > > Please make similar changes elsewhere, as "option's vibrate should not be > presented" isn't clear. Okay, I'll update. Sanghyun Park 2015/04/08 16:37:58 This error.message should be same with throwTypeEr Show quoted text On 2015/04/08 08:00:02, Sanghyun Park wrote: > On 2015/04/07 11:37:31, Peter Beverloo wrote: > > "If options's silent is true, options's vibrate should not be presented." > > --> > > "If the notification is set to silent while a vibration pattern has been > > provided, the Promise is expected to reject." > > > > Please make similar changes elsewhere, as "option's vibrate should not be > > presented" isn't clear. > > Okay, I'll update. > This error.message should be same with throwTypeError message in Notification.cpp. Can I modify this message to "Silent notifications must not specify vibration patterns"? Peter Beverloo 2015/04/08 16:40:01 SGTM Show quoted text On 2015/04/08 16:37:58, Sanghyun Park wrote: > On 2015/04/08 08:00:02, Sanghyun Park wrote: > > On 2015/04/07 11:37:31, Peter Beverloo wrote: > > > "If options's silent is true, options's vibrate should not be presented." > > > --> > > > "If the notification is set to silent while a vibration pattern has been > > > provided, the Promise is expected to reject." > > > > > > Please make similar changes elsewhere, as "option's vibrate should not be > > > presented" isn't clear. > > > > Okay, I'll update. > > > > This error.message should be same with throwTypeError message in > Notification.cpp. > Can I modify this message to "Silent notifications must not specify vibration > patterns"? SGTM
34 test.done();	33 test.done();

35 });	34 });

36	35

37 }).catch(unreached_rejection(test));	36 }).catch(unreached_rejection(test));

38	37

39 }, 'showNotification() must reject if no Web Notification permission has b een granted.');	38 }, 'showNotification() must reject If options\'s silent is true, and optio ns\'s vibrate is presenteded.');

40 </script>	39 </script>

41 </body>	40 </body>

42 </html>	41 </html>

OLD	NEW