Add the vibrate attribute to the Notification object

Source/modules/vibration/NavigatorVibration.cpp

 /*
  *  Copyright (C) 2012 Samsung Electronics
  *
  *  This library is free software; you can redistribute it and/or
  *  modify it under the terms of the GNU Library General Public
  *  License as published by the Free Software Foundation; either
  *  version 2 of the License, or (at your option) any later version.
  *
  *  This library is distributed in the hope that it will be useful,
  *  but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 29 matching lines @@
 }
 
 NavigatorVibration::~NavigatorVibration()
 {
     if (m_isVibrating)
         cancelVibration();
 }
 
 bool NavigatorVibration::vibrate(const VibrationPattern& pattern)
 {
-    VibrationPattern sanitized = pattern;
-    size_t length = sanitized.size();
-
-    // If the pattern is too long then truncate it.
-    if (length > kVibrationPatternLengthMax) {
-        sanitized.shrink(kVibrationPatternLengthMax);
-        length = kVibrationPatternLengthMax;
-    }
-
-    // If any pattern entry is too long then truncate it.
-    for (size_t i = 0; i < length; ++i) {
-        if (sanitized[i] > kVibrationDurationMax)
-            sanitized[i] = kVibrationDurationMax;
-    }
-
-    // If the last item in the pattern is a pause then discard it.
-    if (length && !(length % 2))
-        sanitized.removeLast();
-
     // Cancelling clears the stored pattern so do it before setting the new one.
     if (m_isVibrating)
         cancelVibration();
 
-    m_pattern = sanitized;
+    m_pattern = verifyVibrationPattern(pattern);
 
     if (m_timerStart.isActive())
         m_timerStart.stop();
 
     if (!m_pattern.size())
         return true;
 
     if (m_pattern.size() == 1 && !m_pattern[0]) {
         m_pattern.clear();
         return true;
@@ skipping 77 matching lines @@
 NavigatorVibration& NavigatorVibration::from(Page& page)
 {
     NavigatorVibration* navigatorVibration = static_cast<NavigatorVibration*>(WillBeHeapSupplement<Page>::from(page, supplementName()));
     if (!navigatorVibration) {
         navigatorVibration = new NavigatorVibration(page);
         WillBeHeapSupplement<Page>::provideTo(page, supplementName(), adoptPtrWillBeNoop(navigatorVibration));
     }
     return *navigatorVibration;
 }
 
+NavigatorVibration::VibrationPattern NavigatorVibration::verifyVibrationPattern(const VibrationPattern& pattern)

[Peter Beverloo, 2015/04/01 14:26:29]

s/verify/sanitize? I'd expect a verifyFoo method to return a boolean.

[Sanghyun Park, 2015/04/01 17:46:08]

Done.

+{
+    VibrationPattern sanitized = pattern;
+    size_t length = sanitized.size();
+
+    // If the pattern is too long then truncate it.
+    if (length > kVibrationPatternLengthMax) {
+        sanitized.shrink(kVibrationPatternLengthMax);
+        length = kVibrationPatternLengthMax;
+    }
+
+    // If any pattern entry is too long then truncate it.
+    for (size_t i = 0; i < length; ++i) {
+        if (sanitized[i] > kVibrationDurationMax)
+            sanitized[i] = kVibrationDurationMax;
+    }
+
+    // If the last item in the pattern is a pause then discard it.
+    if (length && !(length % 2))
+        sanitized.removeLast();
+
+    return sanitized;
+}
+
 const char* NavigatorVibration::supplementName()
 {
     return "NavigatorVibration";
 }
 
 DEFINE_TRACE(NavigatorVibration)
 {
     WillBeHeapSupplement<Page>::trace(visitor);
     PageLifecycleObserver::trace(visitor);
 }
 
 } // namespace blink