Source/modules/notifications/NotificationOptions.idl - Issue 1042513002: Add the vibrate attribute to the Notification object

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/modules/notifications/NotificationOptions.idl

Issue 1042513002: Add the vibrate attribute to the Notification object (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Source/modules/notifications/Notification.cpp ('K') | « Source/modules/notifications/Notification.cpp ('k') | Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp » ('j') | Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // http://notifications.spec.whatwg.org/#api	5 // http://notifications.spec.whatwg.org/#api

6	6

7 enum NotificationDirection {	7 enum NotificationDirection {

8 "auto",	8 "auto",

9 "ltr",	9 "ltr",

10 "rtl"	10 "rtl"

11 };	11 };

12	12

	13 typedef (unsigned long or sequence<unsigned long>) VibratePattern;
	Peter Beverloo 2015/04/01 14:26:29 Why can't we share this definition with the Vibrat Why can't we share this definition with the Vibration API? timvolodine 2015/04/01 16:27:17 +1 Show quoted text On 2015/04/01 14:26:29, Peter Beverloo wrote: > Why can't we share this definition with the Vibration API? +1 Sanghyun Park 2015/04/01 17:46:08 Unfortunately, NavigatorVibration.idl did not supp Show quoted text On 2015/04/01 14:26:29, Peter Beverloo wrote: > Why can't we share this definition with the Vibration API? Unfortunately, NavigatorVibration.idl did not support VibratePattern by unionType for now, because of [Clamp] issue. (As I know, unionType does not support [Clamp].) NavigatorVibration.idl uses the overloading function of the two types for now. So, I had no choice.
	14

13 dictionary NotificationOptions {	15 dictionary NotificationOptions {

14 NotificationDirection dir = "auto";	16 NotificationDirection dir = "auto";

15 DOMString lang = "";	17 DOMString lang = "";

16 DOMString body = "";	18 DOMString body = "";

17 DOMString tag = "";	19 DOMString tag = "";

18 DOMString icon;	20 DOMString icon;

19 boolean silent = false;	21 boolean silent = false;

	22 [RuntimeEnabled=NotificationExperimental] VibratePattern vibrate;

20 [RuntimeEnabled=NotificationExperimental] any data = null;	23 [RuntimeEnabled=NotificationExperimental] any data = null;

21 };	24 };

OLD	NEW