Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 1042473002: media: VideoRendererImplTest: wait on buffering change to exit first step (Closed)

Created:
5 years, 9 months ago by llandwerlin-old
Modified:
5 years, 9 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: VideoRendererImplTest: wait on buffering change to exit first step The buffering state change is the last callback fired by VideoRendererImpl, therefore we should wait on this rather than the paint callback. BUG=470517 Committed: https://crrev.com/da2b3023e8da766d258331f80a003c73df06be09 Cr-Commit-Position: refs/heads/master@{#322627}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M media/renderers/video_renderer_impl_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
D tools/valgrind/gtest_exclude/media_unittests.gtest-drmemory.txt View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
llandwerlin-old
PTAL, another try at fixing the DrMemory bots. Thanks.
5 years, 9 months ago (2015-03-27 17:45:25 UTC) #1
llandwerlin-old
5 years, 9 months ago (2015-03-27 17:45:42 UTC) #3
DaleCurtis
lgtm
5 years, 9 months ago (2015-03-27 18:13:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1042473002/1
5 years, 9 months ago (2015-03-27 19:29:01 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-27 19:59:19 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-27 20:00:10 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/da2b3023e8da766d258331f80a003c73df06be09
Cr-Commit-Position: refs/heads/master@{#322627}

Powered by Google App Engine
This is Rietveld 408576698