Issue 22521. Drop '_J2DAccessor' suffixes.

pkg/analyzer/test/generated/resolver_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library engine.resolver_test;
 
 import 'dart:collection';
 
 import 'package:analyzer/src/generated/ast.dart';
 import 'package:analyzer/src/generated/element.dart';
@@ skipping 1839 matching lines @@
         new FileBasedSource.con1(FileUtilities2.createFile("/test.dart"));
     CompilationUnitElementImpl definingCompilationUnit =
         new CompilationUnitElementImpl("test.dart");
     definingCompilationUnit.source = source;
     _definingLibrary = ElementFactory.library(context, "test");
     _definingLibrary.definingCompilationUnit = definingCompilationUnit;
     Library library = new Library(context, _listener, source);
     library.libraryElement = _definingLibrary;
     _visitor = new ResolverVisitor.con1(library, source, _typeProvider);
     try {
-      return _visitor.elementResolver_J2DAccessor as ElementResolver;
+      return _visitor.elementResolver;
     } catch (exception) {
       throw new IllegalArgumentException(
           "Could not create resolver", exception);
     }
   }
 
   /**
    * Return the element associated with the label of [statement] after the
    * resolver has resolved it.  [labelElement] is the label element to be
    * defined in the statement's label scope, and [labelTarget] is the statement
@@ skipping 38 matching lines @@
   /**
    * Return the element associated with the given identifier after the resolver has resolved the
    * identifier.
    *
    * @param node the expression to be resolved
    * @param enclosingClass the element representing the class enclosing the identifier
    * @return the element to which the expression was resolved
    */
   void _resolveInClass(AstNode node, ClassElement enclosingClass) {
     try {
-      Scope outerScope = _visitor.nameScope_J2DAccessor as Scope;
+      Scope outerScope = _visitor.nameScope;
       try {
         _visitor.enclosingClass = enclosingClass;
         EnclosedScope innerScope = new ClassScope(
             new TypeParameterScope(outerScope, enclosingClass), enclosingClass);
-        _visitor.nameScope_J2DAccessor = innerScope;
+        _visitor.nameScope = innerScope;
         node.accept(_resolver);
       } finally {
         _visitor.enclosingClass = null;
-        _visitor.nameScope_J2DAccessor = outerScope;
+        _visitor.nameScope = outerScope;
       }
     } catch (exception) {
       throw new IllegalArgumentException("Could not resolve node", exception);
     }
   }
 
   /**
    * Return the element associated with the given expression after the resolver has resolved the
    * expression.
    *
@@ skipping 12 matching lines @@
    * Return the element associated with the given identifier after the resolver has resolved the
    * identifier.
    *
    * @param node the expression to be resolved
    * @param definedElements the elements that are to be defined in the scope in which the element is
    *          being resolved
    * @return the element to which the expression was resolved
    */
   void _resolveNode(AstNode node, [List<Element> definedElements]) {
     try {
-      Scope outerScope = _visitor.nameScope_J2DAccessor as Scope;
+      Scope outerScope = _visitor.nameScope;
       try {
         EnclosedScope innerScope = new EnclosedScope(outerScope);
         if (definedElements != null) {
           for (Element element in definedElements) {
             innerScope.define(element);
           }
         }
-        _visitor.nameScope_J2DAccessor = innerScope;
+        _visitor.nameScope = innerScope;
         node.accept(_resolver);
       } finally {
-        _visitor.nameScope_J2DAccessor = outerScope;
+        _visitor.nameScope = outerScope;
       }
     } catch (exception) {
       throw new IllegalArgumentException("Could not resolve node", exception);
     }
   }
 
   /**
    * Return the element associated with the label of the given statement after the resolver has
    * resolved the statement.
    *
    * @param statement the statement to be resolved
    * @param labelElement the label element to be defined in the statement's label scope
    * @return the element to which the statement's label was resolved
    */
   void _resolveStatement(
       Statement statement, LabelElementImpl labelElement, AstNode labelTarget) {
     try {
-      LabelScope outerScope = _visitor.labelScope_J2DAccessor as LabelScope;
+      LabelScope outerScope = _visitor.labelScope;
       try {
         LabelScope innerScope;
         if (labelElement == null) {
           innerScope = outerScope;
         } else {
           innerScope = new LabelScope(
               outerScope, labelElement.name, labelTarget, labelElement);
         }
-        _visitor.labelScope_J2DAccessor = innerScope;
+        _visitor.labelScope = innerScope;
         statement.accept(_resolver);
       } finally {
-        _visitor.labelScope_J2DAccessor = outerScope;
+        _visitor.labelScope = outerScope;
       }
     } catch (exception) {
       throw new IllegalArgumentException("Could not resolve node", exception);
     }
   }
 }
 
 @reflectiveTest
 class EnclosedScopeTest extends ResolverTestCase {
   void test_define_duplicate() {
@@ skipping 8895 matching lines @@
         new CompilationUnitElementImpl("lib.dart");
     definingCompilationUnit.source = source;
     LibraryElementImpl definingLibrary =
         new LibraryElementImpl.forNode(context, null);
     definingLibrary.definingCompilationUnit = definingCompilationUnit;
     Library library = new Library(context, _listener, source);
     library.libraryElement = definingLibrary;
     _visitor = new ResolverVisitor.con1(library, source, _typeProvider);
     _visitor.overrideManager.enterScope();
     try {
-      return _visitor.typeAnalyzer_J2DAccessor as StaticTypeAnalyzer;
+      return _visitor.typeAnalyzer;
     } catch (exception) {
       throw new IllegalArgumentException(
           "Could not create analyzer", exception);
     }
   }
 
   DartType _flatten(DartType type) =>
       StaticTypeAnalyzer.flattenFutures(_typeProvider, type);
 
   /**
@@ skipping 2759 matching lines @@
         // check propagated type
         FunctionType propagatedType = node.propagatedType as FunctionType;
         expect(propagatedType.returnType, test.typeProvider.stringType);
       } on AnalysisException catch (e, stackTrace) {
         thrownException[0] = new CaughtException(e, stackTrace);
       }
     }
     return null;
   }
 }