Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1042453002: Fix all errors reported by 'gn check' in components/nacl. (Closed)

Created:
5 years, 9 months ago by tfarina
Modified:
5 years, 9 months ago
Reviewers:
bradnelson, bradn, brettw
CC:
chromium-reviews, Dirk Pranke, scottmg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix all errors reported by 'gn check' in components/nacl. Tested on Linux with the following command line: $ gn gen out-gn --args='enable_nacl=true' $ gn check out-gn //components/nacl/* This should help fix some link errors as well. BUG=367595, 376000 TEST=see above R=bradnelson@google.com,brettw@chromium.org TBR=bradnelson@chromium.org Committed: https://crrev.com/a28055583609850edaa984ed1f54779ffcedacea Cr-Commit-Position: refs/heads/master@{#322707}

Patch Set 1 #

Patch Set 2 : revert change in .gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -3 lines) Patch
M components/nacl/BUILD.gn View 6 chunks +45 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tfarina
PTAL!
5 years, 9 months ago (2015-03-27 15:24:20 UTC) #1
bradn
lgtm
5 years, 9 months ago (2015-03-27 17:06:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1042453002/20001
5 years, 9 months ago (2015-03-28 13:54:47 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-28 14:17:35 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-28 14:18:13 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a28055583609850edaa984ed1f54779ffcedacea
Cr-Commit-Position: refs/heads/master@{#322707}

Powered by Google App Engine
This is Rietveld 408576698