Issue 104243003: Merge bools into bit fields in TextTrackCue and VTTCue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 104243003: Merge bools into bit fields in TextTrackCue and VTTCue (Closed)

Created:
7 years ago by philipj_slow

Modified:
7 years ago

Reviewers:
acolwell GONE FROM CHROMIUM, adamk

CC:
blink-reviews, nessy, philipj_slow, gasubic, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Merge bools into bit fields in TextTrackCue and VTTCue On x86_64 Linux, this reduces sizeof(VTTCue) from 248 to 232. This does likely not result in real runtime savings, but is a step back from 256, where a real memory increase is likely. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163183

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -13 lines)			Patch
M	Source/core/html/track/TextTrackCue.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/html/track/vtt/VTTCue.h	View	1 chunk	+5 lines, -9 lines	0 comments	Download
M	Source/core/html/track/vtt/VTTCue.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/104243003/1

7 years ago (2013-12-04 16:24:41 UTC) #3

Message was sent while issue was closed.

Change committed as 163183

Expand Messages | Collapse Messages