components/autofill/core/browser/webdata/autofill_wallet_syncable_service.cc - Issue 1042353003: Create syncable metadata table for Wallet credit cards and addresses.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/webdata/autofill_wallet_syncable_service.cc

Issue 1042353003: Create syncable metadata table for Wallet credit cards and addresses. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comment about migration code Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/webdata/autofill_table_unittest.cc ('k') | components/autofill/core/browser/webdata/autofill_webdata.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/webdata/autofill_wallet_syncable_service.cc

diff --git a/components/autofill/core/browser/webdata/autofill_wallet_syncable_service.cc b/components/autofill/core/browser/webdata/autofill_wallet_syncable_service.cc

index e4e0d05170cf681e93a9af4b24bdbb53d5fa53a7..e49fda75eb58dcb42a350bcc55a28896eff7758c 100644

--- a/components/autofill/core/browser/webdata/autofill_wallet_syncable_service.cc

+++ b/components/autofill/core/browser/webdata/autofill_wallet_syncable_service.cc

@@ -76,7 +76,7 @@ CreditCard CardFromSpecifics(const sync_pb::WalletMaskedCreditCard& card) {

AutofillProfile ProfileFromSpecifics(

const sync_pb::WalletPostalAddress& address) {

- AutofillProfile profile(AutofillProfile::SERVER_PROFILE, address.id());

+ AutofillProfile profile(AutofillProfile::SERVER_PROFILE, std::string());

// AutofillProfile stores multi-line addresses with newline separators.

std::vector<std::string> street_address(address.street_address().begin(),

@@ -109,6 +109,8 @@ AutofillProfile ProfileFromSpecifics(

base::UTF8ToUTF16(address.phone_number()),

profile.language_code());

+ profile.GenerateServerProfileIdentifier();

return profile;

}