Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: components/autofill/core/browser/autofill_profile.h

Issue 1042353003: Create syncable metadata table for Wallet credit cards and addresses. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: docs Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_profile.h
diff --git a/components/autofill/core/browser/autofill_profile.h b/components/autofill/core/browser/autofill_profile.h
index 597ff0418dc89e1c2b3ee66444eafd7695ea65b8..f94cf83af92c8b79744f7d28d977515c82863cef 100644
--- a/components/autofill/core/browser/autofill_profile.h
+++ b/components/autofill/core/browser/autofill_profile.h
@@ -42,7 +42,8 @@ class AutofillProfile : public AutofillDataModel {
AutofillProfile(const std::string& guid, const std::string& origin);
// Server profile constructor. The type must be SERVER_PROFILE (this serves
- // to differentiate this constructor).
+ // to differentiate this constructor). |server_id| can be empty. If empty,
+ // callers should invoke GenerateServerProfileIdentifier after setting data.
AutofillProfile(RecordType type, const std::string& server_id);
// For use in STL containers.
@@ -181,6 +182,9 @@ class AutofillProfile : public AutofillDataModel {
// Nonempty only when type() == SERVER_PROFILE.
const std::string& server_id() const { return server_id_; }
+ // FIXME documentation
brettw 2015/04/07 18:04:06 finish this.
Evan Stade 2015/04/07 19:23:32 Done.
+ void GenerateServerProfileIdentifier();
+
// Returns a standardized representation of the given string for comparison
// purposes. The resulting string will be lower-cased with all punctuation
// substituted by spaces. Whitespace will be converted to ASCII space, and
@@ -257,7 +261,8 @@ class AutofillProfile : public AutofillDataModel {
// The BCP 47 language code that can be used to format |address_| for display.
std::string language_code_;
- // ID assigned by the server. This will be set only for WALLET_PROFILEs.
+ // ID used for identifying this profile. Only set for SERVER_PROFILEs. This is
+ // a hash of the contents.
std::string server_id_;
};

Powered by Google App Engine
This is Rietveld 408576698