Issue 1042293004: Fix 'gn check' errors in //ui/* and add to default checked set

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1042293004: Fix 'gn check' errors in //ui/* and add to default checked set (Closed)

Created:
5 years, 8 months ago by jamesr

Modified:
5 years, 8 months ago

Reviewers:
sky

CC:
mojo-reviews_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -6 lines)			Patch
M	.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/base/BUILD.gn	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	ui/events/platform/BUILD.gn	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	ui/gfx/BUILD.gn	View	3 chunks	+7 lines, -3 lines	0 comments	Download

Total messages: 4 (1 generated)

jamesr

This was waiting on some upstream fixes which finally rolled in

5 years, 8 months ago (2015-03-30 17:48:11 UTC) #2

jamesr

5 years, 8 months ago (2015-03-30 18:04:08 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
1a33049b113a454c66792f136406cceed04af40b (presubmit successful).