Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 1042263002: Oilpan: Make Oilpan crash at a never-inlined function when hitting OOM (Closed)

Created:
5 years, 8 months ago by haraken
Modified:
5 years, 8 months ago
Reviewers:
oilpan-reviews, sof
CC:
blink-reviews, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: Make Oilpan crash at a never-inlined function when hitting OOM In order to get reliable crash reports of OOM, we want to make Oilpan crash at a never-inlined function. This CL adds blinkGCOutOfMemory for that purpose. BUG=420515 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192760

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
M Source/platform/heap/Heap.cpp View 1 2 2 chunks +20 lines, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
haraken
PTAL
5 years, 8 months ago (2015-03-30 07:38:55 UTC) #2
sof
lgtm % issue below addressed. https://codereview.chromium.org/1042263002/diff/1/Source/platform/heap/Heap.cpp File Source/platform/heap/Heap.cpp (right): https://codereview.chromium.org/1042263002/diff/1/Source/platform/heap/Heap.cpp#newcode175 Source/platform/heap/Heap.cpp:175: IMMEDIATE_CRASH(); Could you mimic ...
5 years, 8 months ago (2015-03-30 08:06:33 UTC) #3
haraken
https://codereview.chromium.org/1042263002/diff/1/Source/platform/heap/Heap.cpp File Source/platform/heap/Heap.cpp (right): https://codereview.chromium.org/1042263002/diff/1/Source/platform/heap/Heap.cpp#newcode175 Source/platform/heap/Heap.cpp:175: IMMEDIATE_CRASH(); On 2015/03/30 08:06:33, sof wrote: > Could you ...
5 years, 8 months ago (2015-03-30 09:24:13 UTC) #4
sof
On 2015/03/30 09:24:13, haraken wrote: > https://codereview.chromium.org/1042263002/diff/1/Source/platform/heap/Heap.cpp > File Source/platform/heap/Heap.cpp (right): > > https://codereview.chromium.org/1042263002/diff/1/Source/platform/heap/Heap.cpp#newcode175 > ...
5 years, 8 months ago (2015-03-30 13:37:49 UTC) #5
haraken
On 2015/03/30 13:37:49, sof wrote: > On 2015/03/30 09:24:13, haraken wrote: > > > https://codereview.chromium.org/1042263002/diff/1/Source/platform/heap/Heap.cpp ...
5 years, 8 months ago (2015-03-30 13:48:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1042263002/40001
5 years, 8 months ago (2015-03-30 13:48:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1042263002/60001
5 years, 8 months ago (2015-03-30 13:49:38 UTC) #12
commit-bot: I haz the power
5 years, 8 months ago (2015-03-30 15:02:00 UTC) #13
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192760

Powered by Google App Engine
This is Rietveld 408576698