Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Side by Side Diff: src/hydrogen-instructions.h

Issue 104203003: Remove unused trigonometric code. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: addressed comment Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/heap-inl.h ('k') | src/hydrogen-instructions.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2620 matching lines...) Expand 10 before | Expand all | Expand 10 after
2631 if (index == 0) { 2631 if (index == 0) {
2632 return Representation::Tagged(); 2632 return Representation::Tagged();
2633 } else { 2633 } else {
2634 switch (op_) { 2634 switch (op_) {
2635 case kMathFloor: 2635 case kMathFloor:
2636 case kMathRound: 2636 case kMathRound:
2637 case kMathSqrt: 2637 case kMathSqrt:
2638 case kMathPowHalf: 2638 case kMathPowHalf:
2639 case kMathLog: 2639 case kMathLog:
2640 case kMathExp: 2640 case kMathExp:
2641 case kMathSin:
2642 case kMathCos:
2643 case kMathTan:
2644 return Representation::Double(); 2641 return Representation::Double();
2645 case kMathAbs: 2642 case kMathAbs:
2646 return representation(); 2643 return representation();
2647 default: 2644 default:
2648 UNREACHABLE(); 2645 UNREACHABLE();
2649 return Representation::None(); 2646 return Representation::None();
2650 } 2647 }
2651 } 2648 }
2652 } 2649 }
2653 2650
(...skipping 24 matching lines...) Expand all
2678 set_representation(Representation::Integer32()); 2675 set_representation(Representation::Integer32());
2679 break; 2676 break;
2680 case kMathAbs: 2677 case kMathAbs:
2681 // Not setting representation here: it is None intentionally. 2678 // Not setting representation here: it is None intentionally.
2682 SetFlag(kFlexibleRepresentation); 2679 SetFlag(kFlexibleRepresentation);
2683 // TODO(svenpanne) This flag is actually only needed if representation() 2680 // TODO(svenpanne) This flag is actually only needed if representation()
2684 // is tagged, and not when it is an unboxed double or unboxed integer. 2681 // is tagged, and not when it is an unboxed double or unboxed integer.
2685 SetGVNFlag(kChangesNewSpacePromotion); 2682 SetGVNFlag(kChangesNewSpacePromotion);
2686 break; 2683 break;
2687 case kMathLog: 2684 case kMathLog:
2688 case kMathSin:
2689 case kMathCos:
2690 case kMathTan:
2691 set_representation(Representation::Double()); 2685 set_representation(Representation::Double());
2692 // These operations use the TranscendentalCache, so they may allocate. 2686 // These operations use the TranscendentalCache, so they may allocate.
2693 SetGVNFlag(kChangesNewSpacePromotion); 2687 SetGVNFlag(kChangesNewSpacePromotion);
2694 break; 2688 break;
2695 case kMathExp: 2689 case kMathExp:
2696 case kMathSqrt: 2690 case kMathSqrt:
2697 case kMathPowHalf: 2691 case kMathPowHalf:
2698 set_representation(Representation::Double()); 2692 set_representation(Representation::Double());
2699 break; 2693 break;
2700 default: 2694 default:
(...skipping 4797 matching lines...) Expand 10 before | Expand all | Expand 10 after
7498 virtual bool IsDeletable() const V8_OVERRIDE { return true; } 7492 virtual bool IsDeletable() const V8_OVERRIDE { return true; }
7499 }; 7493 };
7500 7494
7501 7495
7502 #undef DECLARE_INSTRUCTION 7496 #undef DECLARE_INSTRUCTION
7503 #undef DECLARE_CONCRETE_INSTRUCTION 7497 #undef DECLARE_CONCRETE_INSTRUCTION
7504 7498
7505 } } // namespace v8::internal 7499 } } // namespace v8::internal
7506 7500
7507 #endif // V8_HYDROGEN_INSTRUCTIONS_H_ 7501 #endif // V8_HYDROGEN_INSTRUCTIONS_H_
OLDNEW
« no previous file with comments | « src/heap-inl.h ('k') | src/hydrogen-instructions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698