Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 104203003: Remove unused trigonometric code. (Closed)

Created:
7 years ago by Yang
Modified:
7 years ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Patch Set 4 : addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -766 lines) Patch
M src/arm/code-stubs-arm.cc View 2 chunks +0 lines, -15 lines 0 comments Download
M src/arm/codegen-arm.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/arm/lithium-arm.h View 4 chunks +0 lines, -42 lines 0 comments Download
M src/arm/lithium-arm.cc View 3 chunks +0 lines, -25 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M src/assembler.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/assembler.cc View 1 chunk +0 lines, -39 lines 0 comments Download
M src/heap.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/heap-inl.h View 1 2 1 chunk +1 line, -14 lines 0 comments Download
M src/hydrogen-instructions.h View 2 chunks +0 lines, -6 lines 0 comments Download
M src/hydrogen-instructions.cc View 3 chunks +0 lines, -13 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 2 chunks +4 lines, -92 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M src/ia32/lithium-ia32.h View 4 chunks +0 lines, -42 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 2 chunks +0 lines, -24 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 2 chunks +0 lines, -17 lines 0 comments Download
M src/mips/codegen-mips.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M src/mips/lithium-mips.h View 4 chunks +0 lines, -42 lines 0 comments Download
M src/mips/lithium-mips.cc View 2 chunks +0 lines, -24 lines 0 comments Download
M src/objects.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/platform.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/platform-posix.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M src/platform-win32.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M src/runtime.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/runtime.cc View 1 7 chunks +4 lines, -34 lines 0 comments Download
M src/v8-counters.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 2 chunks +4 lines, -96 lines 0 comments Download
M src/x64/codegen-x64.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M src/x64/lithium-x64.h View 4 chunks +0 lines, -42 lines 0 comments Download
M src/x64/lithium-x64.cc View 2 chunks +0 lines, -24 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
7 years ago (2013-12-04 10:04:54 UTC) #1
Jakob Kummerow
LGTM. https://codereview.chromium.org/104203003/diff/1/src/heap-inl.h File src/heap-inl.h (left): https://codereview.chromium.org/104203003/diff/1/src/heap-inl.h#oldcode774 src/heap-inl.h:774: case EXP: You can delete EXP while you ...
7 years ago (2013-12-04 10:21:05 UTC) #2
Yang
7 years ago (2013-12-04 11:39:43 UTC) #3
Message was sent while issue was closed.
Committed patchset #4 manually as r18256.

Powered by Google App Engine
This is Rietveld 408576698