Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1041973002: Added myself to some guestview-related OWNERS files. (Closed)

Created:
5 years, 9 months ago by paulmeyer
Modified:
5 years, 9 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added myself to some guestview-related OWNERS files. Committed: https://crrev.com/5f681cc59082ad1e8a05f6921595661e6dc1bdf9 Cr-Commit-Position: refs/heads/master@{#322670}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
D chrome/browser/extensions/api/guest_view/OWNERS View 1 chunk +0 lines, -2 lines 2 comments Download
M extensions/common/api/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/renderer/resources/guest_view/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
paulmeyer
+fsamuel@
5 years, 9 months ago (2015-03-27 22:17:54 UTC) #2
Fady Samuel
https://codereview.chromium.org/1041973002/diff/1/chrome/browser/extensions/api/guest_view/OWNERS File chrome/browser/extensions/api/guest_view/OWNERS (left): https://codereview.chromium.org/1041973002/diff/1/chrome/browser/extensions/api/guest_view/OWNERS#oldcode1 chrome/browser/extensions/api/guest_view/OWNERS:1: fsamuel@chromium.org What happened here?
5 years, 9 months ago (2015-03-27 22:20:53 UTC) #3
paulmeyer
https://codereview.chromium.org/1041973002/diff/1/chrome/browser/extensions/api/guest_view/OWNERS File chrome/browser/extensions/api/guest_view/OWNERS (left): https://codereview.chromium.org/1041973002/diff/1/chrome/browser/extensions/api/guest_view/OWNERS#oldcode1 chrome/browser/extensions/api/guest_view/OWNERS:1: fsamuel@chromium.org On 2015/03/27 22:20:53, Fady Samuel wrote: > What ...
5 years, 9 months ago (2015-03-27 22:29:51 UTC) #4
Fady Samuel
lgtm
5 years, 9 months ago (2015-03-27 22:30:22 UTC) #5
paulmeyer
+rockot@
5 years, 9 months ago (2015-03-27 22:44:10 UTC) #7
Ken Rockot(use gerrit already)
lgtm
5 years, 9 months ago (2015-03-27 22:48:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1041973002/1
5 years, 9 months ago (2015-03-27 22:49:42 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-27 23:14:14 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-27 23:14:54 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/5f681cc59082ad1e8a05f6921595661e6dc1bdf9
Cr-Commit-Position: refs/heads/master@{#322670}

Powered by Google App Engine
This is Rietveld 408576698