Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 1041883002: Port generate_gles2_conform_embedded_files action to GN build. (Closed)

Created:
5 years, 9 months ago by tfarina
Modified:
5 years, 9 months ago
Reviewers:
Dirk Pranke, no sievers
CC:
chromium-reviews, piman+watch_chromium.org, brettw, scottmg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Port generate_gles2_conform_embedded_files action to GN build. It requires internal test files, hence it was not tested. Partially tested on Linux with the following command lines: $ gn gen out-gn --args='internal_gles2_conform_tests' BUG=432959 TEST=see above R=dpranke@chromium.org,sievers@chromium.org Committed: https://crrev.com/c0d45b8572d49861651342cb01fd85f956dc3309 Cr-Commit-Position: refs/heads/master@{#322639}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M build/config/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M gpu/gles2_conform_support/BUILD.gn View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
tfarina
5 years, 9 months ago (2015-03-27 18:53:56 UTC) #1
Dirk Pranke
lgtm
5 years, 9 months ago (2015-03-27 20:24:10 UTC) #2
no sievers
lgtm
5 years, 9 months ago (2015-03-27 20:36:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1041883002/1
5 years, 9 months ago (2015-03-27 20:49:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-27 20:53:22 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-27 20:54:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c0d45b8572d49861651342cb01fd85f956dc3309
Cr-Commit-Position: refs/heads/master@{#322639}

Powered by Google App Engine
This is Rietveld 408576698