Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 1041863003: Effen error if a component ancestor doesn't specify a style (Closed)

Created:
5 years, 8 months ago by hansmuller
Modified:
5 years, 8 months ago
Reviewers:
hansmuller1, rafaelw, ojan
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Effen error if a component ancestor doesn't specify a style If a component ancestor doesn't specify a style, quietly ignore it. Currently the result is a little confusing: [0330/124031:ERROR:dart_error.cc(20)] Unhandled exception: Uncaught Error: The null object does not have a getter '_className'. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/b9a77c537c1202fe1e16d9819d578fe0c7ded1d8

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M sky/framework/fn.dart View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 8 (3 generated)
hansmuller1
PTAL
5 years, 8 months ago (2015-03-30 19:59:12 UTC) #3
ojan
lgtm Raf is on leave for the next 5 weeks. This seems reasonable to me ...
5 years, 8 months ago (2015-03-30 20:44:11 UTC) #5
hansmuller
Committed patchset #1 (id:1) manually as b9a77c537c1202fe1e16d9819d578fe0c7ded1d8 (presubmit successful).
5 years, 8 months ago (2015-03-30 21:16:49 UTC) #6
rafaelw
Did the case arise that a stylenode legitimately had no style? Seems like the other ...
5 years, 8 months ago (2015-03-31 01:24:14 UTC) #7
hansmuller1
5 years, 8 months ago (2015-03-31 14:49:42 UTC) #8
Message was sent while issue was closed.
On 2015/03/31 01:24:14, rafaelw wrote:
> Did the case arise that a stylenode legitimately had no style? Seems like the
> other option here is to make the creation of stylenode without a style an
error.

The Material class creates a StyleNode with a null style if the level: parameter
is 0 or unspecified. I assume that's legitimate?

Powered by Google App Engine
This is Rietveld 408576698