Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 1041763002: Remove stale-while-revalidate experimental implementation. (Closed)

Created:
5 years, 9 months ago by Adam Rice
Modified:
5 years, 6 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, eroman, arv+watch_chromium.org, asvitkine+watch_chromium.org, Randy Smith (Not in Mondays)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove stale-while-revalidate experimental implementation. This is in preparation for adding the new implementation. This is a partial revert of commit 64c07d7959386d30a0e4aa1371e2bdcd3d436476. Parts which will still be needed in the new implementation have been left. BUG=348877 TEST=net_unittests Committed: https://crrev.com/b38b3f9fbe286d7305d89d5089d18a423d9ab2bc Cr-Commit-Position: refs/heads/master@{#335252}

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Add missing header includes. #

Total comments: 6

Patch Set 4 : Remove accidental iwyu fix. #

Patch Set 5 : Remove SOURCE_TYPE(IPV6_REACHABILITY_CHECK) #

Patch Set 6 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -776 lines) Patch
M chrome/browser/io_thread.h View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/io_thread.cc View 1 2 3 4 5 5 chunks +0 lines, -16 lines 0 comments Download
M chrome/browser/resources/net_internals/source_entry.js View 1 chunk +0 lines, -1 line 0 comments Download
M net/base/load_flags_list.h View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M net/http/http_cache.h View 1 2 3 4 5 6 chunks +0 lines, -29 lines 0 comments Download
M net/http/http_cache.cc View 1 2 3 4 5 7 chunks +0 lines, -198 lines 0 comments Download
M net/http/http_cache_transaction.h View 1 2 3 4 5 1 chunk +0 lines, -3 lines 0 comments Download
M net/http/http_cache_transaction.cc View 1 2 3 4 5 5 chunks +1 line, -38 lines 0 comments Download
M net/http/http_cache_unittest.cc View 1 2 3 4 5 3 chunks +28 lines, -461 lines 0 comments Download
M net/http/http_network_session.h View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M net/http/http_network_session.cc View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M net/log/net_log_event_type_list.h View 1 1 chunk +0 lines, -23 lines 0 comments Download
M net/log/net_log_source_type_list.h View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (9 generated)
Adam Rice
5 years, 6 months ago (2015-06-01 10:39:06 UTC) #2
Adam Rice
+mmenke: Can you find a reviewer for this? I would ask rvargas, but he appears ...
5 years, 6 months ago (2015-06-09 12:43:32 UTC) #4
mmenke
[+rdsmith]: Are you a reasonable reviewer for this? I'll review the chrome/browser changes once someone ...
5 years, 6 months ago (2015-06-09 15:43:37 UTC) #6
Randy Smith (Not in Mondays)
I'm inclined to think that +gavinp is a better reviewer than I, but if he ...
5 years, 6 months ago (2015-06-09 19:16:25 UTC) #8
gavinp
On 2015/06/09 19:16:25, rdsmith wrote: > I'm inclined to think that +gavinp is a better ...
5 years, 6 months ago (2015-06-16 23:11:10 UTC) #10
gavinp
lgtm in Cache, just a few nit type questions. https://codereview.chromium.org/1041763002/diff/40001/net/base/load_flags_list.h File net/base/load_flags_list.h (right): https://codereview.chromium.org/1041763002/diff/40001/net/base/load_flags_list.h#newcode89 net/base/load_flags_list.h:89: ...
5 years, 6 months ago (2015-06-16 23:54:46 UTC) #11
Adam Rice
https://codereview.chromium.org/1041763002/diff/40001/net/base/load_flags_list.h File net/base/load_flags_list.h (right): https://codereview.chromium.org/1041763002/diff/40001/net/base/load_flags_list.h#newcode89 net/base/load_flags_list.h:89: On 2015/06/16 23:54:45, gavinp wrote: > I think this ...
5 years, 6 months ago (2015-06-17 10:18:01 UTC) #12
Adam Rice
+asvitkine for histograms.xml
5 years, 6 months ago (2015-06-18 07:18:07 UTC) #14
Alexei Svitkine (slow)
lgtm
5 years, 6 months ago (2015-06-18 18:46:26 UTC) #15
Adam Rice
+mmenke could you review the changes in chrome/?
5 years, 6 months ago (2015-06-19 07:01:31 UTC) #17
mmenke
On 2015/06/19 07:01:31, Adam Rice wrote: > +mmenke could you review the changes in chrome/? ...
5 years, 6 months ago (2015-06-19 12:12:13 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1041763002/100001
5 years, 6 months ago (2015-06-19 12:12:57 UTC) #21
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 6 months ago (2015-06-19 13:24:17 UTC) #22
commit-bot: I haz the power
5 years, 6 months ago (2015-06-19 13:25:02 UTC) #23
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/b38b3f9fbe286d7305d89d5089d18a423d9ab2bc
Cr-Commit-Position: refs/heads/master@{#335252}

Powered by Google App Engine
This is Rietveld 408576698