Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Side by Side Diff: src/builtins.cc

Issue 1041753002: fast path for api function creation (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/builtins.h ('k') | src/execution.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/api.h" 7 #include "src/api.h"
8 #include "src/api-natives.h" 8 #include "src/api-natives.h"
9 #include "src/arguments.h" 9 #include "src/arguments.h"
10 #include "src/base/once.h" 10 #include "src/base/once.h"
(...skipping 1129 matching lines...) Expand 10 before | Expand all | Expand 10 after
1140 1140
1141 private: 1141 private:
1142 DISALLOW_COPY_AND_ASSIGN(RelocatableArguments); 1142 DISALLOW_COPY_AND_ASSIGN(RelocatableArguments);
1143 }; 1143 };
1144 1144
1145 } // namespace 1145 } // namespace
1146 1146
1147 1147
1148 MaybeHandle<Object> Builtins::InvokeApiFunction(Handle<JSFunction> function, 1148 MaybeHandle<Object> Builtins::InvokeApiFunction(Handle<JSFunction> function,
1149 Handle<Object> receiver, 1149 Handle<Object> receiver,
1150 int argc, 1150 int argc, Handle<Object> args[],
1151 Handle<Object> args[]) { 1151 bool is_construct) {
1152 // Construct BuiltinArguments object: function, arguments reversed, receiver. 1152 // Construct BuiltinArguments object: function, arguments reversed, receiver.
1153 const int kBufferSize = 32; 1153 const int kBufferSize = 32;
1154 Object* small_argv[kBufferSize]; 1154 Object* small_argv[kBufferSize];
1155 Object** argv; 1155 Object** argv;
1156 if (argc + 2 <= kBufferSize) { 1156 if (argc + 2 <= kBufferSize) {
1157 argv = small_argv; 1157 argv = small_argv;
1158 } else { 1158 } else {
1159 argv = new Object* [argc + 2]; 1159 argv = new Object* [argc + 2];
1160 } 1160 }
1161 argv[argc + 1] = *receiver; 1161 argv[argc + 1] = *receiver;
1162 for (int i = 0; i < argc; ++i) { 1162 for (int i = 0; i < argc; ++i) {
1163 argv[argc - i] = *args[i]; 1163 argv[argc - i] = *args[i];
1164 } 1164 }
1165 argv[0] = *function; 1165 argv[0] = *function;
1166 MaybeHandle<Object> result; 1166 MaybeHandle<Object> result;
1167 { 1167 {
1168 auto isolate = function->GetIsolate(); 1168 auto isolate = function->GetIsolate();
1169 RelocatableArguments arguments(isolate, argc + 2, &argv[argc + 1]); 1169 RelocatableArguments arguments(isolate, argc + 2, &argv[argc + 1]);
1170 result = HandleApiCallHelper<false>(isolate, arguments); 1170 if (is_construct) {
1171 result = HandleApiCallHelper<true>(isolate, arguments);
1172 } else {
1173 result = HandleApiCallHelper<false>(isolate, arguments);
1174 }
1171 } 1175 }
1172 if (argv != small_argv) { 1176 if (argv != small_argv) {
1173 delete[] argv; 1177 delete[] argv;
1174 } 1178 }
1175 return result; 1179 return result;
1176 } 1180 }
1177 1181
1178 1182
1179 // Helper function to handle calls to non-function objects created through the 1183 // Helper function to handle calls to non-function objects created through the
1180 // API. The object can be called as either a constructor (using new) or just as 1184 // API. The object can be called as either a constructor (using new) or just as
(...skipping 470 matching lines...) Expand 10 before | Expand all | Expand 10 after
1651 } 1655 }
1652 BUILTIN_LIST_C(DEFINE_BUILTIN_ACCESSOR_C) 1656 BUILTIN_LIST_C(DEFINE_BUILTIN_ACCESSOR_C)
1653 BUILTIN_LIST_A(DEFINE_BUILTIN_ACCESSOR_A) 1657 BUILTIN_LIST_A(DEFINE_BUILTIN_ACCESSOR_A)
1654 BUILTIN_LIST_H(DEFINE_BUILTIN_ACCESSOR_H) 1658 BUILTIN_LIST_H(DEFINE_BUILTIN_ACCESSOR_H)
1655 BUILTIN_LIST_DEBUG_A(DEFINE_BUILTIN_ACCESSOR_A) 1659 BUILTIN_LIST_DEBUG_A(DEFINE_BUILTIN_ACCESSOR_A)
1656 #undef DEFINE_BUILTIN_ACCESSOR_C 1660 #undef DEFINE_BUILTIN_ACCESSOR_C
1657 #undef DEFINE_BUILTIN_ACCESSOR_A 1661 #undef DEFINE_BUILTIN_ACCESSOR_A
1658 1662
1659 1663
1660 } } // namespace v8::internal 1664 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/builtins.h ('k') | src/execution.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698