Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 104173002: Reland "Implement hyperbolic math functions for ES6." (Closed)

Created:
7 years ago by Yang
Modified:
7 years ago
Reviewers:
Jarin
CC:
v8-dev
Visibility:
Public.

Description

Reland "Implement hyperbolic math functions for ES6." BUG=v8:2938 LOG=N R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18258

Patch Set 1 #

Patch Set 2 : Remove dependency from C math functions. #

Patch Set 3 : better deal with large negative input for asinh #

Unified diffs Side-by-side diffs Delta from patch set Stats (+202 lines, -1 line) Patch
M src/harmony-math.js View 1 2 1 chunk +70 lines, -1 line 0 comments Download
A test/mjsunit/harmony/math-hyperbolic.js View 1 2 1 chunk +132 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Yang
Please take a look. The second patch set is the fix.
7 years ago (2013-12-04 09:14:04 UTC) #1
Jarin
lgtm. thanks.
7 years ago (2013-12-04 09:21:07 UTC) #2
Yang
On 2013/12/04 09:21:07, jarin wrote: > lgtm. > > thanks. I updated the implementation for ...
7 years ago (2013-12-04 12:13:50 UTC) #3
Jarin
LGTM
7 years ago (2013-12-04 16:03:10 UTC) #4
Dmitry Lomov (no reviews)
sheriff's notice: ok to land since this is under the flag
7 years ago (2013-12-04 16:55:26 UTC) #5
Yang
7 years ago (2013-12-05 12:36:49 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r18258.

Powered by Google App Engine
This is Rietveld 408576698