Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 1041723002: Added %_NewConsString intrinsic. (Closed)

Created:
5 years, 9 months ago by Sven Panne
Modified:
5 years, 8 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Added %_NewConsString intrinsic. No compiler support for now (BTW: %_NewString, doesn't have that, either), inline allocation will come later. Hopefully the last intrisic to add for a StringAddStub POC... Committed: https://crrev.com/0a7d4f496a554028de0ab5a963c3a004e693b4cb Cr-Commit-Position: refs/heads/master@{#27508}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -5 lines) Patch
M src/factory.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/factory.cc View 1 chunk +24 lines, -4 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-strings.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-run-intrinsics.cc View 2 chunks +13 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Sven Panne
5 years, 9 months ago (2015-03-27 13:23:20 UTC) #2
Jarin
lgtm
5 years, 9 months ago (2015-03-27 14:09:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1041723002/1
5 years, 8 months ago (2015-03-30 05:52:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-03-30 06:28:43 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-03-30 06:29:01 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0a7d4f496a554028de0ab5a963c3a004e693b4cb
Cr-Commit-Position: refs/heads/master@{#27508}

Powered by Google App Engine
This is Rietveld 408576698