Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1041643003: Add ThreadLogMessages and its test (Closed)

Created:
5 years, 9 months ago by Mark Mentovai
Modified:
5 years, 8 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

Add ThreadLogMessages and its test. This updates mini_chromium to 91ea4908ffd74d9c886bd2f8ccbfae6d31c499af. The last five commits listed here are required to support this change. The mini_chromium update includes: c1745a924c5c Fix paths to atomicops files in base.gyp from 2f02dcc73536 108e9247189c Add #include of <unistd.h> to close_nocancel.cc 6e4f98a9edf8 Add logging::SetLogMessageHandler() 4063fcb8f460 Add base::ThreadLocalStorage 4870f18a33a6 Add base::LazyInstance 0d31b1f3a289 Fix base/memory/aligned_memory.h for MSVC 91ea4908ffd7 base/logging.h: DCHECK() should always reference its condition BUG=crashpad:26 TEST=crashpad_util_test ThreadLogMessages.* R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/e95224bbe7db2a08595a1bdf1c94ca51fbeb23a6

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Patch Set 4 : DEPS #

Patch Set 5 : Address review feedback #

Patch Set 6 : MSVC #

Patch Set 7 : Update mini_chromium to 91ea4908ffd7 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+340 lines, -1 line) Patch
M DEPS View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
A util/thread/thread_log_messages.h View 1 2 1 chunk +48 lines, -0 lines 0 comments Download
A util/thread/thread_log_messages.cc View 1 2 3 4 1 chunk +98 lines, -0 lines 0 comments Download
A util/thread/thread_log_messages_test.cc View 1 2 3 4 5 1 chunk +190 lines, -0 lines 0 comments Download
M util/util.gyp View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
This depends on https://codereview.chromium.org/1039143004/ and https://codereview.chromium.org/1039823002/.
5 years, 9 months ago (2015-03-27 21:35:01 UTC) #2
Robert Sesek
LGTM https://codereview.chromium.org/1041643003/diff/40001/util/thread/thread_log_messages.cc File util/thread/thread_log_messages.cc (right): https://codereview.chromium.org/1041643003/diff/40001/util/thread/thread_log_messages.cc#newcode60 util/thread/thread_log_messages.cc:60: const char* file_poath, nit: file_path
5 years, 8 months ago (2015-03-30 15:34:38 UTC) #3
Mark Mentovai
5 years, 8 months ago (2015-03-30 18:51:40 UTC) #4
Message was sent while issue was closed.
Committed patchset #7 (id:120001) manually as
e95224bbe7db2a08595a1bdf1c94ca51fbeb23a6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698