Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 1041633002: Revert of [turbofan][arm64] Match fneg for -0.0 - x pattern. (Closed)

Created:
5 years, 9 months ago by Yang
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan][arm64] Match fneg for -0.0 - x pattern. (patchset #1 id:1 of https://codereview.chromium.org/1013743006/) Reason for revert: Revert due to crash. Original issue's description: > [turbofan][arm64] Match fneg for -0.0 - x pattern. > > Note that this patch add an extra bit to the ArchOpcodeField. > > R=bmeurer@chromium.org > > Committed: https://crrev.com/fe7441225100660d01e66ce3bcaefe368f62df81 > Cr-Commit-Position: refs/heads/master@{#27494} TBR=bmeurer@chromium.org,baptiste.afsa@arm.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/98580e4b8300abaa3891f8f4d48f94ff053b2924 Cr-Commit-Position: refs/heads/master@{#27495}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -38 lines) Patch
M src/compiler/arm64/code-generator-arm64.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/arm64/instruction-codes-arm64.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 chunk +9 lines, -14 lines 0 comments Download
M src/compiler/instruction-codes.h View 1 chunk +5 lines, -5 lines 0 comments Download
M test/unittests/compiler/arm64/instruction-selector-arm64-unittest.cc View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Yang
Created Revert of [turbofan][arm64] Match fneg for -0.0 - x pattern.
5 years, 9 months ago (2015-03-27 09:11:32 UTC) #1
Yang
On 2015/03/27 09:11:32, Yang wrote: > Created Revert of [turbofan][arm64] Match fneg for -0.0 - ...
5 years, 9 months ago (2015-03-27 09:11:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1041633002/1
5 years, 9 months ago (2015-03-27 09:11:46 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-27 09:11:56 UTC) #4
commit-bot: I haz the power
5 years, 9 months ago (2015-03-27 09:12:13 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/98580e4b8300abaa3891f8f4d48f94ff053b2924
Cr-Commit-Position: refs/heads/master@{#27495}

Powered by Google App Engine
This is Rietveld 408576698