Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 1041593002: Revert of Reland "Filter invalid slots out from the SlotsBuffer after marking." (Closed)

Created:
5 years, 9 months ago by Igor Sheludko
Modified:
5 years, 9 months ago
Reviewers:
ulan, Michael Achenbach
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Reland "Filter invalid slots out from the SlotsBuffer after marking." (patchset #2 id:2 of https://codereview.chromium.org/1032833002/) Reason for revert: Reverting risky GC changes that block v8 roll. Original issue's description: > Reland "Filter invalid slots out from the SlotsBuffer after marking." > > > There are two reasons that could cause invalid slots appearance in SlotsBuffer: > > 1) If GC trims "tail" of an array for which it has already recorded a slots and then migrate another object to the "tail". > > 2) Tagged slot could become a double slot after migrating of an object to another map with "shifted" fields (for example as a result of generalizing immutable data property to a data field). > > > This CL also adds useful machinery that helps triggering incremental write barriers. > > > BUG=chromium:454297 > > LOG=Y > > NOTRY=true > > Committed: https://crrev.com/f86aadd1d45c756467dff8e08a055b462d7a060b > Cr-Commit-Position: refs/heads/master@{#27433} TBR=machenbach@chromium.org,ulan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/de018fbda32e8ac57d8440e8fe6c3d3386bb9b11 Cr-Commit-Position: refs/heads/master@{#27491}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -404 lines) Patch
M src/flag-definitions.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/heap/mark-compact.h View 3 chunks +3 lines, -14 lines 0 comments Download
M src/heap/mark-compact.cc View 9 chunks +22 lines, -157 lines 0 comments Download
M src/heap/spaces.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/heap/store-buffer.cc View 2 chunks +7 lines, -9 lines 0 comments Download
M test/cctest/test-unboxed-doubles.cc View 2 chunks +0 lines, -213 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Igor Sheludko
Created Revert of Reland "Filter invalid slots out from the SlotsBuffer after marking."
5 years, 9 months ago (2015-03-27 06:50:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1041593002/1
5 years, 9 months ago (2015-03-27 06:50:48 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-27 06:51:08 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-27 06:51:25 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/de018fbda32e8ac57d8440e8fe6c3d3386bb9b11
Cr-Commit-Position: refs/heads/master@{#27491}

Powered by Google App Engine
This is Rietveld 408576698