Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 1041533002: Enable BrowserTests AppIdSwitch and ShouldShowLocationBar on Mac OS (Closed)

Created:
5 years, 9 months ago by hcarmona
Modified:
5 years, 9 months ago
Reviewers:
msw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable BrowserTests AppIdSwitch and ShouldShowLocationBar on Mac OS These tests were created before Mac OS supported app windows. Attempting to enable. BUG=NONE Committed: https://crrev.com/ea9bddc232066b05446ddf28b08f9111fc3b8c2d Cr-Commit-Position: refs/heads/master@{#322638}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M chrome/browser/ui/browser_browsertest.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
hcarmona
Trying to enable the test from our email conversation yesterday. Trybots look green.
5 years, 9 months ago (2015-03-27 16:53:07 UTC) #2
msw
lgtm
5 years, 9 months ago (2015-03-27 18:40:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1041533002/1
5 years, 9 months ago (2015-03-27 20:33:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-27 20:38:03 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-27 20:38:58 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ea9bddc232066b05446ddf28b08f9111fc3b8c2d
Cr-Commit-Position: refs/heads/master@{#322638}

Powered by Google App Engine
This is Rietveld 408576698