Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(801)

Unified Diff: Source/web/FrameLoaderClientImpl.cpp

Issue 1041473002: Detach old frame on WebFrame::swap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/FrameLoaderClientImpl.h ('k') | Source/web/RemoteFrameClientImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/FrameLoaderClientImpl.cpp
diff --git a/Source/web/FrameLoaderClientImpl.cpp b/Source/web/FrameLoaderClientImpl.cpp
index fc41acfc6b21e5c3e0dcf96fb595e8b483f3df4c..d1d7afe4f92082c25babf6e5de49ef271fa3123d 100644
--- a/Source/web/FrameLoaderClientImpl.cpp
+++ b/Source/web/FrameLoaderClientImpl.cpp
@@ -315,7 +315,7 @@ void FrameLoaderClientImpl::willBeDetached()
m_webFrame->willBeDetached();
}
-void FrameLoaderClientImpl::detached()
+void FrameLoaderClientImpl::detached(FrameDetachType type)
{
// Alert the client that the frame is being detached. This is the last
// chance we have to communicate with the client.
@@ -331,7 +331,7 @@ void FrameLoaderClientImpl::detached()
// place at this point since we are no longer associated with the Page.
m_webFrame->setClient(0);
- client->frameDetached(m_webFrame);
+ client->frameDetached(m_webFrame, static_cast<WebFrameClient::DetachType>(type));
// Clear our reference to LocalFrame at the very end, in case the client
// refers to it.
m_webFrame->setCoreFrame(nullptr);
« no previous file with comments | « Source/web/FrameLoaderClientImpl.h ('k') | Source/web/RemoteFrameClientImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698