Source/core/frame/LocalFrame.h - Issue 1041473002: Detach old frame on WebFrame::swap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/LocalFrame.h

Issue 1041473002: Detach old frame on WebFrame::swap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebase, addressing dcheng's comments Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/frame/LocalFrame.h

diff --git a/Source/core/frame/LocalFrame.h b/Source/core/frame/LocalFrame.h

index 8f154aaaf53c0562614c7860d68a7e8c42665bec..1e5bda9989fdcce83e383f4b3cff1da51c91d630 100644

--- a/Source/core/frame/LocalFrame.h

+++ b/Source/core/frame/LocalFrame.h

@@ -89,7 +89,7 @@ namespace blink {

void navigate(Document& originDocument, const KURL&, bool lockBackForwardList, UserGestureStatus) override;

void navigate(const FrameLoadRequest&) override;

void reload(FrameLoadType, ClientRedirectPolicy) override;

- void detach() override;

+ void detach(FrameDetachType) override;

void disconnectOwnerElement() override;

SecurityContext* securityContext() const override;

void printNavigationErrorMessage(const Frame&, const char* reason) override;