Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1029)

Unified Diff: Source/core/frame/RemoteFrame.cpp

Issue 1041473002: Detach old frame on WebFrame::swap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/frame/RemoteFrame.cpp
diff --git a/Source/core/frame/RemoteFrame.cpp b/Source/core/frame/RemoteFrame.cpp
index 3ae90324d8aa8ddb2612311a82427c0980bf17b4..c6e694589b32f73c4183d0b988cc5aad07b6af35 100644
--- a/Source/core/frame/RemoteFrame.cpp
+++ b/Source/core/frame/RemoteFrame.cpp
@@ -74,7 +74,7 @@ void RemoteFrame::reload(ReloadPolicy reloadPolicy, ClientRedirectPolicy clientR
remoteFrameClient()->reload(reloadPolicy, clientRedirectPolicy);
}
-void RemoteFrame::detach()
+void RemoteFrame::detach(FrameDetachType type)
{
// Frame::detach() requires the caller to keep a reference to this, since
// otherwise it may clear the last reference to this, causing it to be
@@ -86,7 +86,7 @@ void RemoteFrame::detach()
client()->willBeDetached();
m_windowProxyManager->clearForClose();
setView(nullptr);
- Frame::detach();
+ Frame::detach(type);
}
RemoteSecurityContext* RemoteFrame::securityContext() const

Powered by Google App Engine
This is Rietveld 408576698