Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Unified Diff: Source/web/tests/FrameTestHelpers.cpp

Issue 1041473002: Detach old frame on WebFrame::swap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: tests and cleanup Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/tests/FrameTestHelpers.cpp
diff --git a/Source/web/tests/FrameTestHelpers.cpp b/Source/web/tests/FrameTestHelpers.cpp
index f91064e1d62629411ae60ed560f6efa11396ceb5..ad217a7a32d66f2dd62218b6dd6a39c9abce3234 100644
--- a/Source/web/tests/FrameTestHelpers.cpp
+++ b/Source/web/tests/FrameTestHelpers.cpp
@@ -292,9 +292,9 @@ WebFrame* TestWebFrameClient::createChildFrame(WebLocalFrame* parent, WebTreeSco
return frame;
}
-void TestWebFrameClient::frameDetached(WebFrame* frame)
+void TestWebFrameClient::frameDetached(WebFrame* frame, DetachType type)
{
- if (frame->parent())
+ if (type == DetachType::Remove && frame->parent())
frame->parent()->removeChild(frame);
frame->close();
}
@@ -330,9 +330,9 @@ TestWebRemoteFrameClient::TestWebRemoteFrameClient()
{
}
-void TestWebRemoteFrameClient::frameDetached()
+void TestWebRemoteFrameClient::frameDetached(DetachType type)
{
- if (m_frame->parent())
+ if (type == DetachType::Remove && m_frame->parent())
m_frame->parent()->removeChild(m_frame);
m_frame->close();
}

Powered by Google App Engine
This is Rietveld 408576698