Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(947)

Unified Diff: Source/core/frame/Frame.h

Issue 1041473002: Detach old frame on WebFrame::swap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: tests and cleanup Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/frame/Frame.cpp » ('j') | Source/web/FrameLoaderClientImpl.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/frame/Frame.h
diff --git a/Source/core/frame/Frame.h b/Source/core/frame/Frame.h
index bccaf64b1edd41d460a508173fbd9aa9b447ea3b..5137db7750e128ee4207c6b1b377b2c4caa7faa4 100644
--- a/Source/core/frame/Frame.h
+++ b/Source/core/frame/Frame.h
@@ -53,6 +53,8 @@ class Settings;
class WindowProxy;
class WindowProxyManager;
+enum class DetachType { Remove, Swap };
dcheng 2015/06/04 00:58:23 Let's call this FrameDetachType if we're going to
lfg 2015/06/04 19:16:57 Done.
+
// Status of user gesture.
enum class UserGestureStatus { Active, None };
@@ -71,7 +73,7 @@ public:
virtual void navigate(Document& originDocument, const KURL&, bool lockBackForwardList, UserGestureStatus) = 0;
virtual void reload(ReloadPolicy, ClientRedirectPolicy) = 0;
- virtual void detach();
+ virtual void detach(DetachType);
void detachChildren();
virtual void disconnectOwnerElement();
@@ -98,6 +100,7 @@ public:
Frame* findFrameForNavigation(const AtomicString& name, Frame& activeFrame);
Frame* findUnsafeParentScrollPropagationBoundary();
+ void prepareSwapFrom(Frame*);
void finishSwapFrom(Frame*);
bool canNavigate(const Frame&);
« no previous file with comments | « no previous file | Source/core/frame/Frame.cpp » ('j') | Source/web/FrameLoaderClientImpl.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698