Source/core/html/HTMLTextFormControlElement.cpp - Issue 1041463003: Remove methods of TextIterator that take Range objects

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLTextFormControlElement.cpp

Issue 1041463003: Remove methods of TextIterator that take Range objects (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Add assertions Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLTextFormControlElement.cpp

diff --git a/Source/core/html/HTMLTextFormControlElement.cpp b/Source/core/html/HTMLTextFormControlElement.cpp

index ab88a69cb94915dc5aaf5cfd0935e9ea02aa6eb2..e5dd4a162a85dd38feaaecbc357f448d78255b9a 100644

--- a/Source/core/html/HTMLTextFormControlElement.cpp

+++ b/Source/core/html/HTMLTextFormControlElement.cpp

@@ -414,7 +414,7 @@ int HTMLTextFormControlElement::indexForVisiblePosition(const VisiblePosition& p

RefPtrWillBeRawPtr<Range> range = Range::create(*indexPosition.document());

range->setStart(innerEditorElement(), 0, ASSERT_NO_EXCEPTION);

range->setEnd(indexPosition.containerNode(), indexPosition.offsetInContainerNode(), ASSERT_NO_EXCEPTION);

- return TextIterator::rangeLength(range.get());

+ return TextIterator::rangeLength(range->startPosition(), range->endPosition());

}

int HTMLTextFormControlElement::selectionStart() const