Source/core/editing/htmlediting.cpp - Issue 1041463003: Remove methods of TextIterator that take Range objects

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/htmlediting.cpp

Issue 1041463003: Remove methods of TextIterator that take Range objects (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Add assertions Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/editing/htmlediting.cpp

diff --git a/Source/core/editing/htmlediting.cpp b/Source/core/editing/htmlediting.cpp

index 22d87c90db0a2c122a570e8dcc986797f8d481a0..f36ea5afb019d4b001381f8f4a0657cfe4771ac0 100644

--- a/Source/core/editing/htmlediting.cpp

+++ b/Source/core/editing/htmlediting.cpp

@@ -1097,7 +1097,7 @@ int indexForVisiblePosition(const VisiblePosition& visiblePosition, RefPtrWillBe

RefPtrWillBeRawPtr<Range> range = Range::create(document, firstPositionInNode(scope.get()), p.parentAnchoredEquivalent());

- return TextIterator::rangeLength(range.get(), true);

+ return TextIterator::rangeLength(range->startPosition(), range->endPosition(), true);

}

VisiblePosition visiblePositionForIndex(int index, ContainerNode* scope)