Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 1041463002: Align file_manager cr-dialog-close button to left in rtl locale (Closed)

Created:
5 years, 8 months ago by tbarzic
Modified:
5 years, 8 months ago
Reviewers:
mtomasz
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Align file_manager cr-dialog-close button to left in rtl locale. TEST=Open suggest apps dialog in ar locale, the dialog button should be on the left BUG=None Committed: https://crrev.com/d532c182b9c7df2a25787d06897cd954607dafb7 Cr-Commit-Position: refs/heads/master@{#322513}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M ui/file_manager/file_manager/foreground/css/common.css View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tbarzic
5 years, 8 months ago (2015-03-26 22:22:15 UTC) #2
mtomasz
lgtm, thanks for fixing
5 years, 8 months ago (2015-03-27 00:17:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1041463002/1
5 years, 8 months ago (2015-03-27 00:17:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-03-27 00:46:55 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-03-27 00:48:10 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d532c182b9c7df2a25787d06897cd954607dafb7
Cr-Commit-Position: refs/heads/master@{#322513}

Powered by Google App Engine
This is Rietveld 408576698