Expose an API on ArrayBufferView to copy out content w/o changing the buffer

src/api.cc

Index: src/api.cc
diff --git a/src/api.cc b/src/api.cc
index f6398aedf5ea50100398db2b73a20edb5984c9b8..358e4d9c6f85038f384b6c2a8c8170b4ffe3d1c3 100644
--- a/src/api.cc
+++ b/src/api.cc
@@ -6425,6 +6425,37 @@ Local<ArrayBuffer> v8::ArrayBufferView::Buffer() {
 }
 
 
+size_t v8::ArrayBufferView::CopyContents(void* dest, size_t byte_length) {
+  i::Handle<i::JSArrayBufferView> obj = Utils::OpenHandle(this);
+  size_t byte_offset = static_cast<size_t>(obj->byte_offset()->Number());

[Dmitry Lomov (no reviews), 2015/04/01 08:48:57]

Use NumberToSize function

+  size_t bytes_to_copy =
+      i::Min(byte_length, static_cast<size_t>(obj->byte_length()->Number()));

[Dmitry Lomov (no reviews), 2015/04/01 08:48:57]

Use NumberToSize function

+  if (bytes_to_copy) {
+    const char* source = nullptr;

[Dmitry Lomov (no reviews), 2015/04/01 08:48:57]

Since you operate with raw pointers into V8 heap, use DisallowHeapAllocation to
make sure no gc happens

+    if (obj->IsJSDataView()) {
+      i::Handle<i::JSDataView> data_view(i::JSDataView::cast(*obj));
+      i::Handle<i::JSArrayBuffer> buffer(
+          i::JSArrayBuffer::cast(data_view->buffer()));
+      source = reinterpret_cast<char*>(buffer->backing_store());
+    } else {
+      DCHECK(obj->IsJSTypedArray());
+      i::Handle<i::JSTypedArray> typed_array(i::JSTypedArray::cast(*obj));
+      if (typed_array->buffer()->IsSmi()) {
+        i::Handle<i::FixedTypedArrayBase> fixed_array(
+            i::FixedTypedArrayBase::cast(typed_array->elements()));
+        source = reinterpret_cast<char*>(fixed_array->DataPtr());
+      } else {
+        i::Handle<i::JSArrayBuffer> buffer(
+            i::JSArrayBuffer::cast(typed_array->buffer()));
+        source = reinterpret_cast<char*>(buffer->backing_store());
+      }
+    }
+    memcpy(dest, source + byte_offset, bytes_to_copy);
+  }
+  return bytes_to_copy;
+}
+
+
 size_t v8::ArrayBufferView::ByteOffset() {
   i::Handle<i::JSArrayBufferView> obj = Utils::OpenHandle(this);
   return static_cast<size_t>(obj->byte_offset()->Number());