Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 1041403003: Expose an API on ArrayBufferView to copy out content w/o changing the buffer (Closed)

Created:
5 years, 8 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 8 months ago
CC:
Paweł Hajdan Jr., v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Expose an API on ArrayBufferView to copy out content w/o changing the buffer BUG=v8:3996 LOG=y R=dslomov@chromium.org,kbr@chromium.org,hpayer@chromium.org Committed: https://crrev.com/2a5eb8299b2fa13d57d1d4741d4f121df1c3e883 Cr-Commit-Position: refs/heads/master@{#27580}

Patch Set 1 #

Patch Set 2 : updates #

Patch Set 3 : updates #

Total comments: 4

Patch Set 4 : updates #

Patch Set 5 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -0 lines) Patch
M include/v8.h View 1 2 3 1 chunk +11 lines, -0 lines 0 comments Download
M src/api.cc View 1 2 3 1 chunk +33 lines, -0 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A test/cctest/test-typedarrays.cc View 1 2 3 4 1 chunk +79 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (1 generated)
jochen (gone - plz use gerrit)
5 years, 8 months ago (2015-03-31 16:11:13 UTC) #1
jochen (gone - plz use gerrit)
ptal
5 years, 8 months ago (2015-03-31 16:39:15 UTC) #2
jochen (gone - plz use gerrit)
https://codereview.chromium.org/1041403003/diff/40001/test/cctest/test-typedarrays.cc File test/cctest/test-typedarrays.cc (right): https://codereview.chromium.org/1041403003/diff/40001/test/cctest/test-typedarrays.cc#newcode47 test/cctest/test-typedarrays.cc:47: "var a = new Uint8Array(4);" this is actually the ...
5 years, 8 months ago (2015-03-31 16:40:27 UTC) #3
Dmitry Lomov (no reviews)
https://codereview.chromium.org/1041403003/diff/40001/src/api.cc File src/api.cc (right): https://codereview.chromium.org/1041403003/diff/40001/src/api.cc#newcode6430 src/api.cc:6430: size_t byte_offset = static_cast<size_t>(obj->byte_offset()->Number()); Use NumberToSize function https://codereview.chromium.org/1041403003/diff/40001/src/api.cc#newcode6432 src/api.cc:6432: ...
5 years, 8 months ago (2015-04-01 08:48:57 UTC) #4
jochen (gone - plz use gerrit)
ptal
5 years, 8 months ago (2015-04-02 08:20:03 UTC) #5
Dmitry Lomov (no reviews)
lgtm
5 years, 8 months ago (2015-04-02 09:34:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1041403003/80001
5 years, 8 months ago (2015-04-02 09:35:04 UTC) #8
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 8 months ago (2015-04-02 09:36:42 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-02 09:36:55 UTC) #10
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/2a5eb8299b2fa13d57d1d4741d4f121df1c3e883
Cr-Commit-Position: refs/heads/master@{#27580}

Powered by Google App Engine
This is Rietveld 408576698