Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 1041363002: Add a stub implementation of khronos_glcts_test to the GN build. (Closed)

Created:
5 years, 8 months ago by Dirk Pranke
Modified:
5 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@add_gyp_only
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a stub implementation of khronos_glcts_test to the GN build. The bulk of the test suite requires internal test files, and so we'll defer porting it to GN to a later date, but for now at least we'll have a skeleton to hang that work on. R=kbr@chromium.org BUG=471903, 461019 CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg Committed: https://crrev.com/e0422842dc0deae15c616006ada98782d2a67b40 Cr-Commit-Position: refs/heads/master@{#322976}

Patch Set 1 #

Patch Set 2 : add missing BUILD.gn file #

Patch Set 3 : add bug numbers for remaining work on gpu targets that need internal stuff #

Patch Set 4 : merge to #322930 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -4 lines) Patch
M BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M build/gn_migration.gypi View 1 2 3 2 chunks +3 lines, -4 lines 0 comments Download
A gpu/khronos_glcts_support/BUILD.gn View 1 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
Dirk Pranke
5 years, 8 months ago (2015-03-30 23:23:44 UTC) #1
Ken Russell (switch to Gerrit)
Thanks for taking care of this. LGTM
5 years, 8 months ago (2015-03-31 00:26:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1041363002/40001
5 years, 8 months ago (2015-03-31 00:36:56 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/10066) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 8 months ago (2015-03-31 00:41:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1041363002/60001
5 years, 8 months ago (2015-03-31 00:52:29 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/52837)
5 years, 8 months ago (2015-03-31 01:05:17 UTC) #13
Ken Russell (switch to Gerrit)
piman or sievers: OWNERS review please.
5 years, 8 months ago (2015-03-31 02:01:30 UTC) #15
piman
lgtm
5 years, 8 months ago (2015-03-31 04:03:58 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1041363002/60001
5 years, 8 months ago (2015-03-31 04:20:40 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 8 months ago (2015-03-31 04:24:20 UTC) #19
commit-bot: I haz the power
5 years, 8 months ago (2015-03-31 04:25:03 UTC) #20
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/e0422842dc0deae15c616006ada98782d2a67b40
Cr-Commit-Position: refs/heads/master@{#322976}

Powered by Google App Engine
This is Rietveld 408576698