Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Unified Diff: media/formats/webm/webm_video_client.cc

Issue 1041353002: media-internals: Differentiate error, info, and debug log messages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address reviewer comments Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/formats/webm/webm_video_client.cc
diff --git a/media/formats/webm/webm_video_client.cc b/media/formats/webm/webm_video_client.cc
index 592475f092c996531e949c4fe824c1fd70666a03..9de87e234108834060cc627cf242eaca24f9554c 100644
--- a/media/formats/webm/webm_video_client.cc
+++ b/media/formats/webm/webm_video_client.cc
@@ -44,7 +44,7 @@ bool WebMVideoClient::InitializeConfig(
video_codec = kCodecVP9;
profile = VP9PROFILE_ANY;
} else {
- MEDIA_LOG(log_cb_) << "Unsupported video codec_id " << codec_id;
+ MEDIA_LOG(ERROR, log_cb_) << "Unsupported video codec_id " << codec_id;
return false;
}
@@ -83,7 +83,8 @@ bool WebMVideoClient::InitializeConfig(
if (display_width_ <= 0 || display_height_ <= 0)
return false;
} else {
- MEDIA_LOG(log_cb_) << "Unsupported display unit type " << display_unit_;
+ MEDIA_LOG(ERROR, log_cb_) << "Unsupported display unit type "
+ << display_unit_;
return false;
}
gfx::Size natural_size = gfx::Size(display_width_, display_height_);
@@ -139,8 +140,9 @@ bool WebMVideoClient::OnUInt(int id, int64 val) {
}
if (*dst != -1) {
- MEDIA_LOG(log_cb_) << "Multiple values for id " << std::hex << id
- << " specified (" << *dst << " and " << val << ")";
+ MEDIA_LOG(ERROR, log_cb_) << "Multiple values for id " << std::hex << id
+ << " specified (" << *dst << " and " << val
+ << ")";
return false;
}

Powered by Google App Engine
This is Rietveld 408576698