Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(904)

Unified Diff: media/formats/mp4/track_run_iterator.cc

Issue 1041353002: media-internals: Differentiate error, info, and debug log messages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address reviewer comments Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/formats/mp4/track_run_iterator.cc
diff --git a/media/formats/mp4/track_run_iterator.cc b/media/formats/mp4/track_run_iterator.cc
index 604074ca727b2b3a4fca1d0d39eab7ade4b3b87c..a216ba8ccf052686402dd22ef8eae3a43d7341dc 100644
--- a/media/formats/mp4/track_run_iterator.cc
+++ b/media/formats/mp4/track_run_iterator.cc
@@ -157,7 +157,8 @@ static bool PopulateSampleInfo(const TrackExtends& trex,
break;
case kSampleDependsOnReserved:
- MEDIA_LOG(log_cb) << "Reserved value used in sample dependency info.";
+ MEDIA_LOG(ERROR, log_cb) << "Reserved value used in sample dependency"
+ " info.";
return false;
}
return true;
@@ -518,7 +519,7 @@ scoped_ptr<DecryptConfig> TrackRunIterator::GetDecryptConfig() {
if (cenc_info_.empty()) {
DCHECK_EQ(0, aux_info_size());
- MEDIA_LOG(log_cb_) << "Aux Info is not available.";
+ MEDIA_LOG(ERROR, log_cb_) << "Aux Info is not available.";
return scoped_ptr<DecryptConfig>();
}
@@ -530,7 +531,7 @@ scoped_ptr<DecryptConfig> TrackRunIterator::GetDecryptConfig() {
if (!cenc_info.subsamples.empty() &&
(!cenc_info.GetTotalSizeOfSubsamples(&total_size) ||
total_size != static_cast<size_t>(sample_size()))) {
- MEDIA_LOG(log_cb_) << "Incorrect CENC subsample size.";
+ MEDIA_LOG(ERROR, log_cb_) << "Incorrect CENC subsample size.";
return scoped_ptr<DecryptConfig>();
}

Powered by Google App Engine
This is Rietveld 408576698