Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Unified Diff: media/formats/mp4/box_definitions.cc

Issue 1041353002: media-internals: Differentiate error, info, and debug log messages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address reviewer comments Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/formats/mp4/box_definitions.cc
diff --git a/media/formats/mp4/box_definitions.cc b/media/formats/mp4/box_definitions.cc
index fec356afd50fd55215a514bc973d3c59f5d52eca..a08cb26d560ca1b5e99ce066a269017af5d90a9e 100644
--- a/media/formats/mp4/box_definitions.cc
+++ b/media/formats/mp4/box_definitions.cc
@@ -393,10 +393,10 @@ bool AVCDecoderConfigurationRecord::ParseInternal(BufferReader* reader,
RCHECK(sps_list[i].size() > 4);
if (!log_cb.is_null()) {
- MEDIA_LOG(log_cb) << "Video codec: avc1." << std::hex
- << static_cast<int>(sps_list[i][1])
- << static_cast<int>(sps_list[i][2])
- << static_cast<int>(sps_list[i][3]);
+ MEDIA_LOG(INFO, log_cb) << "Video codec: avc1." << std::hex
+ << static_cast<int>(sps_list[i][1])
+ << static_cast<int>(sps_list[i][2])
+ << static_cast<int>(sps_list[i][3]);
}
}
@@ -489,8 +489,8 @@ bool ElementaryStreamDescriptor::Parse(BoxReader* reader) {
object_type = es_desc.object_type();
if (object_type != 0x40) {
- MEDIA_LOG(reader->log_cb()) << "Audio codec: mp4a."
- << std::hex << static_cast<int>(object_type);
+ MEDIA_LOG(INFO, reader->log_cb()) << "Audio codec: mp4a." << std::hex
+ << static_cast<int>(object_type);
}
if (es_desc.IsAAC(object_type))

Powered by Google App Engine
This is Rietveld 408576698