media/filters/source_buffer_stream.h - Issue 1041353002: media-internals: Differentiate error, info, and debug log messages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/filters/source_buffer_stream.h

Issue 1041353002: media-internals: Differentiate error, info, and debug log messages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address reviewer comments Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/filters/source_buffer_stream.h

diff --git a/media/filters/source_buffer_stream.h b/media/filters/source_buffer_stream.h

index 362a9ab6272f49d9a9f33f6af8f9da870397814e..6bca890cf6f57a478bf65cfb942e90fb5bd224dc 100644

--- a/media/filters/source_buffer_stream.h

+++ b/media/filters/source_buffer_stream.h

@@ -324,8 +324,8 @@ class MEDIA_EXPORT SourceBufferStream {

// appropriately and returns true. Otherwise returns false.

bool SetPendingBuffer(scoped_refptr<StreamParserBuffer>* out_buffer);

- // Callback used to report error strings that can help the web developer

- // figure out what is wrong with the content.

+ // Callback used to report log messages that can help the web developer figure

+ // out what is wrong with the content.

LogCB log_cb_;

// List of disjoint buffered ranges, ordered by start time.

« media/base/media_log.cc ('K') | « media/filters/frame_processor_unittest.cc ('k') | media/filters/source_buffer_stream.cc » ('j') | no next file with comments »